Bug 392012 - Duplicated global menu when using mnemonics in undecorated windows
Summary: Duplicated global menu when using mnemonics in undecorated windows
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Global Menu widget (show other bugs)
Version: 5.12.3
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-18 19:33 UTC by Jesse
Modified: 2018-03-26 08:40 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.12.4
Sentry Crash Report:
kde: Usability?


Attachments
duplicated global menu (50.30 KB, image/png)
2018-03-18 19:33 UTC, Jesse
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse 2018-03-18 19:33:06 UTC
Created attachment 111487 [details]
duplicated global menu

If you invoke the global menu using a mnemonic like Alt-F, it gets duplicated if the window has no decoration, like shows the image in attachment.

Steps to reproduce:
1. Put the global menu widget on a panel
2. Open an application that has menu mnemonics, like Dolphin
3. Remove the window decoration in 'Special application settings' by marking 'Yes' for 'No titlebar and frame' under 'Appearance & Fixes' tab
4. Try invoking the global menu with Alt-F.
Comment 1 Kai Uwe Broulik 2018-03-22 08:01:29 UTC
The question is: who should get precedence? They don't know each other. (Not arguing the fact that it's stupid to show both ;)
Comment 2 Jesse 2018-03-22 11:13:09 UTC
I believe the global menu should always have precedence, since the user chose to use it. I'm not sure how to do that technically, since I'm not familiarized neither c++ nor plasma development. Although, I think, the undecorated window could check if a global menu widget exists, and, if it does, just don't show it.
Comment 3 Kai Uwe Broulik 2018-03-22 11:22:34 UTC
The user also explicitly chose to add the title bar to the decoration, right? So there's a bit of a conflict here...
Comment 4 Jesse 2018-03-22 11:32:29 UTC
What does "add the title bar to the decoration" mean? I might be confusing some terms, but when I say window decoration I mean the window's titlebar and border. I don't see how that's related to the app menu.
Comment 5 Kai Uwe Broulik 2018-03-22 13:57:03 UTC
The menu button in the title bar (three lines) has to be placed explicitly by the user and enables accessing the menu through the title bar. If you have both (applet and that button) enabled, how can it know what the user's intention is?
Comment 6 Jesse 2018-03-22 14:07:39 UTC
I don't have the menu in the titlebar, only the global menu widget.
Comment 7 Kai Uwe Broulik 2018-03-22 14:11:02 UTC
Oh, I see. KWin should ignore the signal in that case. Sorry I misunderstood.
Comment 8 Jesse 2018-03-22 14:18:27 UTC
No problem :) Maybe I wasn't clear enough. The existence of the titlebar menu didn't cross my mind until you mentioned it.
Comment 9 Kai Uwe Broulik 2018-03-22 14:28:54 UTC
https://phabricator.kde.org/D11580
Comment 10 Kai Uwe Broulik 2018-03-26 08:40:06 UTC
Git commit c99d329125ac745d4c764c5262a8010e9b565fde by Kai Uwe Broulik.
Committed on 26/03/2018 at 08:39.
Pushed by broulik into branch 'Plasma/5.12'.

[AppMenu] Ignore show request when application menu isn't configured

Before Plasma 5.12 one could only have either global menu or decoration button configured but since the setting was non-intuitive
it was switched to auto-enable when applet or button is present.
This results in both menus reacting to e.g. Alt+F for File menu.
FIXED-IN: 5.12.4

Differential Revision: https://phabricator.kde.org/D11580

M  +10   -0    appmenu.cpp

https://commits.kde.org/kwin/c99d329125ac745d4c764c5262a8010e9b565fde