Created attachment 111430 [details] screenshot Red lines in my screenshot taken on neon dev unstable indicate the large spaces.
Created attachment 111545 [details] unmaximized system settings > cursor kcm Situation is worst when the window is unmaximized.
That's by design and all new settings modules using a grid-style selection will have that
horrible
Kai are you sure? https://phabricator.kde.org/M112/415/
Re-opening since this seems like a visual regression, even if it was intentional. Also, it's not clear that it was a part of the intended design, judging by the mockup. Those were intentionally "low-fidelity" mockups, to avoid getting people hung up on the details. These huge side borders might have been a case of taking the low-fi mockups too literally...
The Grid View is intentionally designed in a way that it will always be a whole number of delegates wide without leaving a gap inside the view or having to resize the delegate to fit. implicitWidth: Math.max(view.cellWidth * 2 + internal.scrollBarSpace , Math.floor(internal.availableWidth / view.cellWidth) * view.cellWidth + internal.scrollBarSpace + 4) It's not like you would gain anything from making the view wider as no more items would fit inside anyway. I'd rather have uniform padding on both sides than random padding inside the grid on the right side of it.
That's a sensible implicitWidth, but you can make widgets bigger than their size hint. I would expect this to fill the available width, without that we'd always show only 2 delegates even if you resize it to fill an screen.
It always grows to accomodate however many delegates would fit its width: Math.floor(internal.availableWidth / view.cellWidth) ← the number of cells that fit
That means that the frame around the delegates jumps around in size and constantly changes its side padding as the window is resized. I'm not a big fan, to be honest. Give it a try; it feels really awkward and jarring.
Because you can resize OpenGL windows smoothly on X to begin with ;))) But do whatever with that. I just stated my opinion.
I agree with this, can we, at least, make it aligned with the title of the KCM? It looks like the title is about 5-10 PX margin. Something similar for the theme area would be good too. However, keep in mind that the more you stretch the window, the margin will become wider because the elements in the window are centered.
Git commit ed25dc5389415d3b03604f042cb70312aaec4225 by Marco Martin. Committed on 16/04/2018 at 14:57. Pushed by mart into branch 'master'. new resize policy Summary: the grid view always takes the full kcm the extra space is added as space between icons columns Test Plan: tested on various sizes Reviewers: #vdg, #plasma Subscribers: broulik, #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D12244 M +7 -7 src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml M +8 -9 src/qmlcontrols/kcmcontrols/qml/GridView.qml M +8 -5 src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml https://commits.kde.org/kdeclarative/ed25dc5389415d3b03604f042cb70312aaec4225