Bug 391899 - Missing icons from icon theme pack
Summary: Missing icons from icon theme pack
Status: RESOLVED DUPLICATE of bug 372966
Alias: None
Product: krusader
Classification: Applications
Component: general (show other bugs)
Version: Git
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-15 21:56 UTC by Daniel
Modified: 2018-05-06 00:15 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel 2018-03-15 21:56:48 UTC
Hello, i have a problem with the newest version of krusader (the one with the pinned tabs feature implemented). I compiled from sources and installed the latest version, as I said in the comments on the request topic (krusader-devel), on my Ubuntu 16.04 system. The problem is, despide the feature is working fine, I have a bug that I haven't in the older version of krusader i was using: some icons are missing (I have changed the icons pack used by krusader via Icons - KDE Control Module ("kcmshell4 icons" command from terminal - I usedf Ubuntu-Mono-Light icons) and the folder icons are not the right ones. I have attached a picture to see it (the text was replaced by an icon from that icon pack in the older version I was using). Alse, if I want to change the icon set, for example back to Breeze set, the icons won't change. It looks like right after installation the program was using the saved files from the older version.
Comment 1 Nikita Melnichenko 2018-03-18 06:34:27 UTC
Exactly the same icons are missing as in the bug #372966.
As a workaround you can try to use a patch from here: https://phabricator.kde.org/D10352

*** This bug has been marked as a duplicate of bug 372966 ***
Comment 2 Daniel 2018-04-08 19:10:51 UTC
The ticket can be closed since I'm no longer using the program.
Comment 3 Nikita Melnichenko 2018-04-22 22:03:40 UTC
Git commit 94ea5b69af14620abd4a44a13240ca9b2749641b by Nikita Melnichenko.
Committed on 22/04/2018 at 22:00.
Pushed by melnichenko into branch 'master'.

Refactored and unified icon rendering, implemented per-icon fallback logic

Merge branch 'fix-missing-icons'

The merged branch contains implementation of per-icon fallback logic:
1. Search icon in the active icon theme — if found, use it.
2. Search it in the icon theme that is specified in Krusader config — if found, use it.
3. Search it in Breeze or Oxygen (in case any of these installed) — if found, use it.
4. Otherwise use a default "icon-missing" icon bundled with Krusader.

FIXED: [ 372964 ] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)
Related: bug 372964, bug 372966, bug 376699, bug 381676, bug 386554, bug 388691

FIXED: [ 372966 ] Some icons are not seen using a plain Ubuntu (not Kubuntu) 16.04

Differential Revision: https://phabricator.kde.org/D10352

M  +11   -10   krusader/kractions.cpp
M  +2    -8    krusader/krusader.cpp

https://commits.kde.org/krusader/94ea5b69af14620abd4a44a13240ca9b2749641b