Bug 391896 - Double menu bar
Summary: Double menu bar
Status: RESOLVED FIXED
Alias: None
Product: krusader
Classification: Applications
Component: general (show other bugs)
Version: Git
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-15 20:59 UTC by Daniel
Modified: 2018-05-06 00:16 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
duplicated menu bar (221.58 KB, image/png)
2018-03-15 20:59 UTC, Daniel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel 2018-03-15 20:59:43 UTC
Created attachment 111423 [details]
duplicated menu bar

Hello, i have a problem with the newest version of krusader (the one with the pinned tabs feature implemented). I compiled from sources and installed the latest version, as I said in the comments on the request topic (krusader-devel), on my Ubuntu 16.04 system. The problem is, despide the feature is working fine, I have a bug which duplicates the menu bar, one under another. I've attached some screenshots to show it.
Comment 1 Nikita Melnichenko 2018-03-18 06:30:33 UTC
Hi Daniel,

It seems to be related to your DE settings that you have a second menu on top of the window header. Since you know how to compile from source, could you please help us to track down the commit that introduced the problem? First, confirm that when you compile from source at the "v2.6.0-master" tag, you don't see double menu. Then you can use `git bisect` or simply checkout different commits and check, gradually decreasing the interval of where it happened. Once localized, we may find a way to address this.
Comment 2 Daniel 2018-03-23 21:57:11 UTC
It is really strange that this bug appears because before this I had installed Krusader from the Ubuntu Software Center and didn't have any problem at all, even it was an older version. To be sure I will install the right version, could you send me the link to that master "v2.6.0-master" please. Thanks!
Comment 3 Nikita Melnichenko 2018-03-24 06:25:37 UTC
It's simple with the following two steps. Make sure you are inside the cloned repository (current dir contains COPYING file).

$ git checkout -b test
Switched to a new branch 'test'
$ git reset --hard v2.6.0-master 
HEAD is now at 377b99f3 New release version: 2.6.0

Then compile the project as usual.

Later I suggest you to use gitk to reset your test branch at different points and check whether it reproduces the issue or not.
Comment 4 Daniel 2018-03-25 16:37:14 UTC
Thanks, I managed to find the version of my download, it is indeed v2.6.0-master as you said. I reinstalled my old krusader 2.4.0-beta 3 from Ubuntu Software Center, which works normally (no double bar, no missing icons). Is it possible to install the one from repo (i uninstalled it before installing the one from Software Center) without uninstalling this older one?
Comment 5 Nikita Melnichenko 2018-03-26 08:13:47 UTC
v2.4 uses KDE4 libs, paths and configs. It doesn't interfere with v2.6 which uses KF5 libs, paths and configs - you can have them both installed. That's being said, you don't have to install krusader every time to test it. Just install master version and compile the version you need - then, from the build dir, run:
./krusader/krusader

It will run the compiled exe.
Comment 6 Daniel 2018-03-26 15:04:57 UTC
I've managed to switch to 2.6.0-master as you said. Short question: for compiling I'm using this tutorial (https://cgit.kde.org/krusader.git/tree/INSTALL): could you tell me which steps I don't need? I'm running:
$ mkdir krusader-build
$ cd krusader-build
$ cmake ../krusader -DCMAKE_INSTALL_PREFIX=/usr/ -DCMAKE_C_FLAGS="-O2 -fPIC" -DCMAKE_CXX_FLAGS="-O2 -fPIC"
$ sudo su -c "make install"
Do I need to edit the last command to not install it, as you said I don't need to install it every time to test it. Thanks!
Comment 7 Nikita Melnichenko 2018-03-27 05:06:26 UTC
Yes, replace the last command with
$ ./krusader/krusader
Comment 8 Daniel 2018-03-27 16:03:24 UTC
I have some problems if running cmake from inside krusader-build folder which was make with the first command (CMake won't work correctly if it's not executed from 
that folder (the parent directory of the "krusader" source code folder)), so when using the cmake (3rd command) from krusader folder it works, but after running ./krusader/krusader I get "bash: ./krusader/krusader: No such file or directory"
Comment 9 Christoph Feck 2018-03-30 23:49:58 UTC
You can use 'ls' and 'cd' commands to check where the actual binary is placed, or a graphical file manager, if you fail to find it in the terminal.
Comment 10 Daniel 2018-04-11 15:10:35 UTC
I've found a similar file manager which works well and has the features needed. The ticket can be closed.