Bug 391821 - Icon of mobile broadband network is sometimes wrong
Summary: Icon of mobile broadband network is sometimes wrong
Status: CLOSED NOT A BUG
Alias: None
Product: plasma-nm
Classification: Plasma
Component: general (show other bugs)
Version: 5.12.3
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Jan Grulich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-13 14:48 UTC by Petr Nehez
Modified: 2018-10-03 09:06 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
network-folder (207.71 KB, image/png)
2018-03-13 14:48 UTC, Petr Nehez
Details
network-folder-ubuntu (207.71 KB, image/png)
2018-03-13 17:23 UTC, Petr Nehez
Details
network-folder-breeze (1.12 MB, image/png)
2018-03-13 17:23 UTC, Petr Nehez
Details
network-folder-breeze-2 (643.02 KB, image/png)
2018-03-13 20:00 UTC, Petr Nehez
Details
lan-network (245.41 KB, image/png)
2018-03-14 07:14 UTC, Petr Nehez
Details
network-with-breeze (281.69 KB, image/png)
2018-05-14 16:50 UTC, Petr Nehez
Details
Patch adding some debug information (2.96 KB, patch)
2018-05-15 08:21 UTC, Jan Grulich
Details
bad-icon.log (9.36 KB, text/x-log)
2018-05-17 09:06 UTC, Petr Nehez
Details
Patch adding some debug information (3.82 KB, patch)
2018-05-28 10:24 UTC, Jan Grulich
Details
plasma-log-limited (181.41 KB, application/zip)
2018-06-07 12:09 UTC, Petr Nehez
Details
plasma-log-limited-2 (1.05 KB, application/zip)
2018-06-07 12:16 UTC, Petr Nehez
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Nehez 2018-03-13 14:48:39 UTC
Created attachment 111368 [details]
network-folder

I use Papirus icon pack on Manjaro (community/papirus-icon-theme) but sometimes broadband icon is wrong - it shows network folder instead.

It happens rarely ONLY with broadband network - neither with Wifi or with LAN.

When I was using Kubuntu I have never met such issue.
Since the time I started to use Manjaro KDE I sometimes face this issue.
Comment 1 Nate Graham 2018-03-13 15:33:51 UTC
Does the issue reproduce using standard Breeze icons?
Comment 2 Petr Nehez 2018-03-13 17:23:05 UTC
Created attachment 111375 [details]
network-folder-ubuntu

When I set Breeze, I had even no icon there.

And when I set Ubuntu icons, I had network folder there as well.
Comment 3 Petr Nehez 2018-03-13 17:23:58 UTC
Created attachment 111376 [details]
network-folder-breeze

This is screenshot with empty icon...
Comment 4 Petr Nehez 2018-03-13 17:26:17 UTC
Strange thing is that icons of plasmoids have not been updated.
I deleted cache, restarted system...
Comment 5 Nate Graham 2018-03-13 17:39:56 UTC
Thanks for the info.
Comment 6 Petr Nehez 2018-03-13 20:00:44 UTC
Created attachment 111384 [details]
network-folder-breeze-2

I changed Look & Feel theme to Breeze Dark because I forgot that plasmoid icons are driven by that but as you can see there is the same issue.
Comment 7 Petr Nehez 2018-03-14 07:14:43 UTC
Created attachment 111388 [details]
lan-network

I am now connected via LAN and the icon is with red circle.

I was connecting & disconnecting to LAN and/or WiFi because I had some issue with the specific WiFi and after disconnecting from WiFi it ended up with this crossed LAN icon.
Comment 8 Christoph Feck 2018-03-30 15:42:06 UTC
Not sure where to reassign to, but I guess plasma-nm developers and VDG team can coordinate this.
Comment 9 Petr Nehez 2018-03-30 17:24:26 UTC
If anybody wants a help I am here as it annoys me.
Comment 10 Petr Nehez 2018-05-01 17:43:12 UTC
Is here anybody who could fix this issue?
I can be helpful on it...
Comment 11 Jan Grulich 2018-05-14 11:37:29 UTC
This seem to be a problem in theme, I would change Plasma theme to "Breeze dark", just the theme, no need to change Look & Feel completely and restart plasmashell.
Comment 12 Petr Nehez 2018-05-14 11:45:59 UTC
OK, I have changed the theme and will be watching it.
But the weird thing is that sometimes the icon is correct but in most cases it's not.
Comment 13 Petr Nehez 2018-05-14 16:50:30 UTC
Created attachment 112648 [details]
network-with-breeze

It seemed OK with Breeze theme until I was on EDGE with VPN and after disconnecting of VPN the network icon was shown. 
But after a while when I was preparing this screenshot it got fixed to correct mobile network icon (most likely due to a change from EDGE to 4G/LTE).
Comment 14 Jan Grulich 2018-05-15 06:10:10 UTC
If I provide a patch adding some debug information, would you be able to compile plasma-nm with it?
Comment 15 Petr Nehez 2018-05-15 06:21:55 UTC
I would try that although I have not compiled any regular package yet.

I am on Manjaro where my plasma-nm is 5.12.5 so I guess I should clone https://cgit.kde.org/plasma-nm.git/log/?h=Plasma/5.12 and then apply a patch?
Comment 16 Petr Nehez 2018-05-15 06:45:29 UTC
OK, I cloned the repo and could compile plasma-nm with this cmake command:

cmake ../ -DCMAKE_INSTALL_PREFIX=/usr

I did not try to install it yet so I can try your patch.
Hopefully my system won't break then 'cause I would break my working env :)
Comment 17 Jan Grulich 2018-05-15 08:21:12 UTC
Created attachment 112661 [details]
Patch adding some debug information

Apply please attached patch. Then please follow information from here https://techbase.kde.org/Projects/Solid/Plasma-nm, specifically part with QT_LOGGING_CATEGORY.
Comment 18 Petr Nehez 2018-05-15 08:25:24 UTC
I don't see anything about QT_LOGGING_CATEGORY there.
Did you mean QT_LOGGING_RULES?
Comment 19 Jan Grulich 2018-05-15 08:26:27 UTC
Yes, sorry for confusion.
Comment 20 Petr Nehez 2018-05-16 09:55:53 UTC
I compiled it with the applied patch,d added "export QT_LOGGING_RULES=plasma-nm*.debug=true" into my .profile file and restarted my system.

Could you help me now where I should see log output?
Comment 21 Jan Grulich 2018-05-16 10:20:53 UTC
You have to open a terminal and restart plasmashell from there, I usually do "killall plasmashell" and then you can just run "plasmashell", then you should get debug output from plasma-nm. It's described also in the link I sent you before.
Comment 22 Petr Nehez 2018-05-17 09:06:31 UTC
Created attachment 112701 [details]
bad-icon.log

It took me a while to replicate it but finally I got the bad icon.

Could it be caused that the modem driver is not responding with the correct signal value?
As you can see there are only 0 values.
I can tell you that the real signal is over 90, in the previous logs I could see the value 93, but that value appeared when I disconnetced and connected to the modem several times.

And what about the icon "network-mobile-0-lte-limited"?
Isn't it that issue?
Comment 23 Petr Nehez 2018-05-17 09:09:23 UTC
I forgot to mention that the connection is working fine when it reports Signal=0.
Comment 24 Petr Nehez 2018-05-17 09:11:28 UTC
And when I connected to VPN (a lock appeared on a modem icon) and then disconnected it, the icon changed to 0-signal modem icon.
Comment 25 Jan Grulich 2018-05-28 10:24:10 UTC
Created attachment 112923 [details]
Patch adding some debug information

Can you please try this patch with more debug information. I still have no idea why this is happening.
Comment 26 Petr Nehez 2018-05-29 05:08:11 UTC
I applied the patch to the master branch and installed the package.

I think the issue is noticeable in areas with weak signal so when I am travelling with the train I will be testing it.

Now when I am in the office and the mobile signal is strong and I play with connecting & disconnecting to/from LAN and/or Wifi and/or mobile I am not able to replicate the issue. I will let you know.
Comment 27 Petr Nehez 2018-05-31 04:38:06 UTC
I was trying to replicate the issue again but unfortunately my modem was not reporting "limited" or "zero" signal for few days what I could see so far.

Isn't the real issue that there are no icons for the suffix "-limited"?
Comment 28 Petr Nehez 2018-05-31 04:42:51 UTC
I am running Plasma with the patched plasma-nm package already for 2 days (with few suspend & resume actions every day) and when I was on modem connection only (in a train) I spent approx 1 hour trying to replicate the issue.

It could be just an issue of my modem which was reporting wrong signal value or an issue of the driver, who knows?
Comment 29 Petr Nehez 2018-06-07 12:09:40 UTC
Created attachment 113132 [details]
plasma-log-limited

Finally after few days I've got the icon for limited signal.
See the attached log.
Comment 30 Petr Nehez 2018-06-07 12:16:45 UTC
Created attachment 113133 [details]
plasma-log-limited-2

And what is strange that the icon in the plasmoid was not change even I could see in the terminal that modem is reporting signal strength at 60%.
Comment 31 Petr Nehez 2018-10-03 08:35:00 UTC
So actually it turned out to be an issue between NM and icons set.

When I created the following symlinks, the icon started to work.

 network-mobile-0-lte-limited.svg -> network-cellular-signal-good.svg
 network-mobile-0-lte.svg -> network-cellular-signal-good.svg
 network-mobile-100-lte.svg -> network-cellular-signal-good.svg
 network-mobile-40-lte.svg -> network-cellular-signal-good.svg
 network-mobile-60-lte.svg -> network-cellular-signal-good.svg
 network-mobile-80-lte.svg -> network-cellular-signal-good.svg

But I do not think creating of such symlinks for in each possible icon set would be the best approach.

What if NM would start using of "network-cellular-signal-*" icons?
Comment 32 Jan Grulich 2018-10-03 08:40:32 UTC
This is weird, we don't use "network-cellular-signal-good" icon name. This looks like your distribution has some custom modifications to plasma-nm applet.
Comment 33 Petr Nehez 2018-10-03 08:49:53 UTC
OK, my bad - "network-cellular-signal-*" icons are from Papirus icons set.

But the point is that if make such symlinks (to any existing icon from Breeze theme) the icon starts to work again.

I have checked https://cgit.kde.org/breeze-icons.git/tree/icons-dark/status/22 and I cannot see there any "network-mobile-*" icon.
Comment 34 Jan Grulich 2018-10-03 08:54:05 UTC
The icons are from plasma theme, they are all stored in one svg. If you want to use a different icons, you need to make sure that all of them are there. If the icon set is not complete, you need to workaround it the way you did or use a different icon set.
Comment 35 Petr Nehez 2018-10-03 09:00:25 UTC
And could you help me where in Breeze theme/icons I can find such icons?
Comment 36 Jan Grulich 2018-10-03 09:02:21 UTC
They are in plasma-framework:
https://cgit.kde.org/plasma-framework.git/tree/src/desktoptheme/breeze/icons/network.svgz
Comment 37 Petr Nehez 2018-10-03 09:06:33 UTC
Thanks, I see.