Bug 391776 - PNGs exported always with the "sRGB built-in (8bpc)" ICC profile
Summary: PNGs exported always with the "sRGB built-in (8bpc)" ICC profile
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: git master (please specify the git hash!)
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-12 19:46 UTC by mvowada
Modified: 2018-07-15 09:09 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
(Video) (2.77 MB, video/mp4)
2018-03-13 09:24 UTC, mvowada
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mvowada 2018-03-12 19:46:25 UTC
(Krita Version: 4.1.0-pre-alpha (git d0e6714) appimage)

When exporting as PNG, the document is always exported with the "sRGB built-in (8bpc)" profile:

    1) create a new document
    2) menu > "File" > "Export" as PNG

Actual Results: PNG is exported with the "sRGB built-in (8bpc)" ICC profile.
Expected Results: use the document ICC profile.
Comment 1 mvowada 2018-03-12 19:50:13 UTC
(same result with Krita 3.3.3)
Comment 2 Halla Rempt 2018-03-13 08:55:54 UTC
Hi,

I'm sorry, but I cannot reproduce that. Note that you do need to uncheck "force sRGB" in the PNG export dialog.
Comment 3 mvowada 2018-03-13 09:24:40 UTC
Created attachment 111363 [details]
(Video)

Hi Boudewijn, thanks for checking.
(In reply to Boudewijn Rempt from comment #2)
> I'm sorry, but I cannot reproduce that. Note that you do need to uncheck
> "force sRGB" in the PNG export dialog.
it appears that the "force sRGB" checkbox in the PNG export dialog here appears checked but grayed out (see video which is a bit longer than usual, I'm sorry).
Comment 4 wolthera 2018-03-13 18:26:04 UTC
This is a side effect of the PNG export dialog being a mess:

1. You can export a png with aces colorspace, not force it sRGB, the 'embed sRGB profile' is disabled but can still be checked from a previous export, this results in the PNG with embedded aces profile.
2. You can have a elle profile, export it. 'force sRGB' will be disabled, might be checked, you cannot uncheck or check it, embed sRGB profile will thus embed the sRGB built-in profile.

I suggest we turn off all disabling code in that dialog for now and then sit down to discuss each and every single usecase before we add in dumb disable things again.
Comment 5 wolthera 2018-03-13 18:31:36 UTC
Git commit 9e69db55115c7aeeaea78f8a1aca9bc8239d9f87 by Wolthera van Hövell tot Westerflier.
Committed on 13/03/2018 at 18:31.
Pushed by woltherav into branch 'krita/4.0'.

Disable disable code in png export dialog for now.

It was not well thought out, lets enable it again when we do think it out.

If you wish to export to sRGB with a custom sRGB profile, check 'embed profile',
don't check 'force srgb'

M  +2    -2    plugins/impex/png/kis_png_export.cc

https://commits.kde.org/krita/9e69db55115c7aeeaea78f8a1aca9bc8239d9f87
Comment 6 wolthera 2018-03-13 18:31:46 UTC
Git commit 4d4f6ddebe40ec997e92cfd68bd70c7f1bdc0ed3 by Wolthera van Hövell tot Westerflier.
Committed on 13/03/2018 at 18:31.
Pushed by woltherav into branch 'master'.

Disable disable code in png export dialog for now.

It was not well thought out, lets enable it again when we do think it out.

If you wish to export to sRGB with a custom sRGB profile, check 'embed profile',
don't check 'force srgb'

M  +2    -2    plugins/impex/png/kis_png_export.cc

https://commits.kde.org/krita/4d4f6ddebe40ec997e92cfd68bd70c7f1bdc0ed3
Comment 7 mvowada 2018-07-15 09:09:08 UTC
It works as expected in Krita 4.2.0-pre-alpha on Linux Ubuntu 14.04. I'm going to close the report. Thanks!