Bug 391600 - Text Editor Menu inaccessible on macOS
Summary: Text Editor Menu inaccessible on macOS
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tool/Text (show other bugs)
Version: git master (please specify the git hash!)
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: Halla Rempt
URL:
Keywords: release_blocker
Depends on:
Blocks:
 
Reported: 2018-03-09 09:31 UTC by Halla Rempt
Modified: 2018-03-17 08:53 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Halla Rempt 2018-03-09 09:31:25 UTC
On MacOS, there can be only one application menu that is shown in the top menubar. The svgtexteditor is a second main window with a menu, so the menu isn't shown. On removing the Tool window flag, this actually leads to a crash.

All menu options should be made available from a menu button or in the toolbar.
Comment 1 Halla Rempt 2018-03-16 09:09:15 UTC
Git commit ba17603826792acee3441578fc9eef448be185c3 by Boudewijn Rempt.
Committed on 16/03/2018 at 09:06.
Pushed by rempt into branch 'master'.

Show the text editor menu on macOS

The only problem was that the editor window had an owner; if it
doesn't, Qt uses the menubar correctly.

M  +1    -1    plugins/tools/svgtexttool/SvgTextTool.cpp

https://commits.kde.org/krita/ba17603826792acee3441578fc9eef448be185c3
Comment 2 Halla Rempt 2018-03-17 08:53:31 UTC
Git commit 444a549b161d280ac6a3ffe5e13f705c626cbc4d by Boudewijn Rempt.
Committed on 17/03/2018 at 08:50.
Pushed by rempt into branch 'krita/4.0'.

Show the text editor menu on macOS

The only problem was that the editor window had an owner; if it
doesn't, Qt uses the menubar correctly.
(cherry picked from commit ba17603826792acee3441578fc9eef448be185c3)

M  +1    -1    plugins/tools/svgtexttool/SvgTextTool.cpp

https://commits.kde.org/krita/444a549b161d280ac6a3ffe5e13f705c626cbc4d