Bug 391598 - QuickLook plugin in the krita.app bundle overrides "public.data"
Summary: QuickLook plugin in the krita.app bundle overrides "public.data"
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Instant Preview (show other bugs)
Version: 3.3.3
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-09 08:38 UTC by Chris Spelberg
Modified: 2018-03-09 11:33 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Spelberg 2018-03-09 08:38:57 UTC
The QuickLook plugin bundled in krita.app registers "public.data" which overrides my local installed plugins 

Since Krita does not render simple text files it should not register the public.data type.

OS: macOS High Sierra
Comment 1 Halla Rempt 2018-03-09 09:28:40 UTC
I have no clue about that, so I'll take your word for it and remove it. Is public.item correct, or should that go as well?
Comment 2 Halla Rempt 2018-03-09 09:29:14 UTC
Git commit ec061a8e52668613974df2bda14a2b143b2a0874 by Boudewijn Rempt.
Committed on 09/03/2018 at 09:28.
Pushed by rempt into branch 'master'.

Remove public.data from quicklook info.plist

M  +0    -1    krita/integration/kritaquicklook/Info.plist

https://commits.kde.org/krita/ec061a8e52668613974df2bda14a2b143b2a0874
Comment 3 Halla Rempt 2018-03-09 09:32:08 UTC
Git commit 47926d5504bc22886db272041521f33496e14fbe by Boudewijn Rempt.
Committed on 09/03/2018 at 09:29.
Pushed by rempt into branch 'krita/4.0'.

Remove public.data from quicklook info.plist

M  +0    -1    krita/integration/kritaquicklook/Info.plist

https://commits.kde.org/krita/47926d5504bc22886db272041521f33496e14fbe
Comment 4 Chris Spelberg 2018-03-09 10:03:14 UTC
Thanks for the quick reply!

My experience with QuickLook is really small, but as a Java developer I have a clue what is going on ;)

Please have a look at this page:
https://developer.apple.com/library/content/documentation/Miscellaneous/Reference/UTIRef/Articles/System-DeclaredUniformTypeIdentifiers.html#//apple_ref/doc/uid/TP40009259-SW1

I think Krita should only support its own format and not preview the generic datatypes.
Comment 5 Halla Rempt 2018-03-09 10:08:58 UTC
Okay. I guess Beelzy just let those items stand because they were there in the example she started from. I'll remove that as well.
Comment 6 Halla Rempt 2018-03-09 10:09:47 UTC
Git commit bb6c57bed894ef52c7798627392de17e2419bbfb by Boudewijn Rempt.
Committed on 09/03/2018 at 10:09.
Pushed by rempt into branch 'krita/4.0'.

Also remove public.item

M  +0    -1    krita/integration/kritaquicklook/Info.plist

https://commits.kde.org/krita/bb6c57bed894ef52c7798627392de17e2419bbfb
Comment 7 Halla Rempt 2018-03-09 10:55:15 UTC
Git commit 2c537a6c529a10ce27c30fa9006fef0d7f0254cc by Boudewijn Rempt.
Committed on 09/03/2018 at 10:55.
Pushed by rempt into branch 'master'.

Also remove public.item
(cherry picked from commit bb6c57bed894ef52c7798627392de17e2419bbfb)

M  +0    -1    krita/integration/kritaquicklook/Info.plist

https://commits.kde.org/krita/2c537a6c529a10ce27c30fa9006fef0d7f0254cc
Comment 8 Chris Spelberg 2018-03-09 11:33:58 UTC
Nice! Thanks!