Bug 391559 - appdata id different from desktop file name
Summary: appdata id different from desktop file name
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: Git
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-08 11:26 UTC by Harald Sitter
Modified: 2018-05-30 12:35 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/umbrello/988fa1ecbfa0aac74912c58f09180c12d539bb68
Version Fixed In: 2.25.80 (KDE Applications 18.07.80)

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2018-03-08 11:26:24 UTC 
appdata has
  <id>org.kde.umbrello.desktop</id>


desktop file is apparently named umbrello.desktop

the appdata also doesn't provide a launchable entry.

all in all I find it entirely unlikey that appstream will be able to properly map the appdata to the desktop file. thus reducing the autogenerated information in the appdata as a whole (e.g. it'd be missing categories)

the desktop file name needs to be changed to use reverse domain notation. RDN is also needed for automatic wayland window-desktopid mapping, so renaming is necessary to get that working anyway.

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable
Comment 1 Ralf Habacker 2018-05-30 11:44:17 UTC 
> desktop file is apparently named umbrello.desktop
you looked in git ? 

With kf5 builds it in installed into /usr/share/applications org.kde.umbrello.desktop, which is probably what you expected.

It would be the choice to rename the file in git repo, but this will not be able in stable branch because of freezed translation state. Instead this would be performed in master branch for 2.26 releases.
Comment 2 Ralf Habacker 2018-05-30 11:45:29 UTC 
Git commit 163a0bed29d443a3456eeb019da2e0bc53535149 by Ralf Habacker.
Committed on 30/05/2018 at 11:45.
Pushed by habacker into branch 'Applications/18.04'.

Add <launchable> entry to umbrello appdata xml file

M  +1    -0    umbrello/org.kde.umbrello.appdata.xml

https://commits.kde.org/umbrello/163a0bed29d443a3456eeb019da2e0bc53535149
Comment 3 Ralf Habacker 2018-05-30 12:31:38 UTC 
Git commit 988fa1ecbfa0aac74912c58f09180c12d539bb68 by Ralf Habacker.
Committed on 30/05/2018 at 12:17.
Pushed by habacker into branch 'master'.

Use reverse domain notation for application desktop file name
FIXED-IN:2.25.80 (KDE Applications 18.07.80)

M  +5    -8    umbrello/CMakeLists.txt
R  +0    -0    umbrello/org.kde.umbrello.desktop [from: umbrello/umbrello.desktop - 100% similarity]

https://commits.kde.org/umbrello/988fa1ecbfa0aac74912c58f09180c12d539bb68
Comment 4 Ralf Habacker 2018-05-30 12:35:58 UTC 
Git commit 6796355a66da37b6b1a9d42e8eb63710298ed690 by Ralf Habacker.
Committed on 30/05/2018 at 12:35.
Pushed by habacker into branch 'master'.

Fixup of commit 988fa1ecbfa0aac74912c58f09180c12d539bb68

Patching binary name in appdata file has been removed and therefore
the binary name need to be updated in the app data file directly.

M  +1    -1    umbrello/org.kde.umbrello.appdata.xml

https://commits.kde.org/umbrello/6796355a66da37b6b1a9d42e8eb63710298ed690