Hi, while performing a Filter>Color>Color-to-Alpha on a document, it is usually possible to go outside the dialog, fly over the canvas with the mouse (the cursor is changing for a color-picker cursor) and pick a color from the canvas to define the color to transform into alpha. In Krita 4.0 this feature doesn't work: the icon appears, but clicking on the canvas doesn't return the selected color.
That's probably caused by: commit 042dbe5190fa613ae53a24236ad3eb19b2b03b16 Author: Dmitry Kazakov <dimula73@gmail.com> Date: Mon Jan 29 16:35:23 2018 +0300 Block all the non-view input user actions while filter dialog is active Now all the input actions are divided into two groups: view-transform and modifying. And the canvas can block any of these action by setting a special flag, that is checked by the shortcuts matcher. When the filter dialog opens, it just blocks all the modifying actions, allowing the view ones at the same time :) BUG:352747 So assigning to Dmitry.
Yeah, the priblem is caused by that change of mine. But atm I cannot tell how to test it correctly... The point is, now color picker uses strokes to pick color from the canvas, taking LoD into account. And filters also use strokes for preview. So I need to invent some way of having both of them at the same time. David, what you'd think about the following solution: 1) When filter dialog is in focus, the on-canvas preview is on 2) Wheb the user activates canvas, on-canvas preview hides, and the user is allowed to pick old color. What would you think of that?
Hey @dmitry. I tested again and I think exposing the color-picker while being hover the canvas can be now removed totally. I explain: If you click on the filter in the color socket ; it calls the color-selector refactored by Wolthera. This color selector embed a color-picker. So the feature now just moved to a more logical place in a way. What do you think about it?
Oh, that would be a time-saving solution :-)
Git commit fd3edfaea7034b34986b6c945baabbd3f2e5c712 by Boudewijn Rempt. Committed on 15/03/2018 at 14:39. Pushed by rempt into branch 'master'. Color To Alpha: Remove the on-canvas color picker The color picker in the color selector dialog is good enough, for now. M +0 -2 plugins/filters/colors/kis_wdg_color_to_alpha.cpp https://commits.kde.org/krita/fd3edfaea7034b34986b6c945baabbd3f2e5c712
Git commit 83a5c2054445d962c5724ac4bd25354dbb8bd388 by Boudewijn Rempt. Committed on 15/03/2018 at 14:40. Pushed by rempt into branch 'krita/4.0'. Color To Alpha: Remove the on-canvas color picker The color picker in the color selector dialog is good enough, for now. M +0 -2 plugins/filters/colors/kis_wdg_color_to_alpha.cpp https://commits.kde.org/krita/83a5c2054445d962c5724ac4bd25354dbb8bd388