Bug 391400 - kalarmcal-17.12.2 can't build with KF5 KHolidays
Summary: kalarmcal-17.12.2 can't build with KF5 KHolidays
Status: RESOLVED DOWNSTREAM
Alias: None
Product: kalarmcal
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.7.3
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-04 22:20 UTC by A. Wilcox (awilfox)
Modified: 2018-03-05 04:17 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
(Temporary patch) (446 bytes, patch)
2018-03-04 22:20 UTC, A. Wilcox (awilfox)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description A. Wilcox (awilfox) 2018-03-04 22:20:55 UTC
Created attachment 111190 [details]
(Temporary patch)

I'm the Adélie Linux KDE maintainer, and we can't make a package of kalarmcal as shipped since the transition to KHolidays being a Framework package:

CMake Error at CMakeLists.txt:44 (find_package):
  Could not find a configuration file for package "KF5Holidays" that is
  compatible with requested version "5.7.2".

  The following configuration files were considered but not accepted:

    /usr/lib/cmake/KF5Holidays/KF5HolidaysConfig.cmake, version: 5.6.2


I've temporarily patched it to accept 5.6.2, since that is the latest ABI version for KHolidays now (even in git master).
Comment 1 Rex Dieter 2018-03-05 00:59:27 UTC
You need to use a matching kholidays-17.12.2 (also part of kde applications with kalarmcal)
Comment 2 Rex Dieter 2018-03-05 01:02:05 UTC
Sorry, I misunderstood, re-opening while I confirm.
Comment 3 Rex Dieter 2018-03-05 02:31:06 UTC
Confirmed it works with kholidays-5.43.0 (and 5.44.0 available to distro packagers), reports itself as version: 5.43.0 , which satisfies >= 5.7.2
Comment 4 A. Wilcox (awilfox) 2018-03-05 04:17:54 UTC
I see the problem; the package manager was seeing stale 17.08.2 in repo and it figured that was higher number than 5.43.0.  Sorry for the noise.