Bug 391399 - Not possible to add location bookmarks in Digikam >5.6.0
Summary: Not possible to add location bookmarks in Digikam >5.6.0
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Geolocation-Bookmarks (show other bugs)
Version: 5.9.0
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-04 21:32 UTC by Jens
Modified: 2018-04-10 16:50 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jens 2018-03-04 21:32:53 UTC
For several Digikam versions (I think since 5.6.0) I cannot add any bookmarks any more using the Geolocation Editor.

I have one single bookmark (my home address) defined which I added a long time ago. Now, when I right-click on an image which has geodata set and select Bookmarks > Add BOokmark ... and then enter some name, nothing happens. The bookmark is not added to the list afterwards.

Can you please check? I have about a dozen locations that keep reappearing in my photos, and bookmarks would help tremendously here.

Thanks!
Comment 1 Maik Qualmann 2018-03-05 20:19:31 UTC
Yes, I can reproduce it. It is only possible to create 1 entry in the "root" menu. The idea is actually that a folder is created in the bookmarks editor. This is then also selectable in the add bookmarks dialog and many bookmarks can be added here. The question is, do we create a hidden "root" folder or a normal folder so that can not be added bookmarks in the "root" menu?

Maik
Comment 2 caulier.gilles 2018-03-05 21:12:32 UTC
This is a good question...

The bookmark manager code is inspired of Qt Web browser example code which include this feature based on standard XBEL format.

https://en.wikipedia.org/wiki/XBEL

Gilles Caulier
Comment 3 Jens 2018-03-05 21:17:33 UTC
From a users perspective, there is only one choice: Create a hidden root folder (and during migration/update move this single entry there). Nobody expects (or understands) why you can only create one single entry - especially because there is no error message when adding entries.
Comment 4 Taras 2018-04-07 18:52:57 UTC
Agree with Jens. From the end user's view bookmarks functionality is broken.
Comment 5 Maik Qualmann 2018-04-10 16:50:31 UTC
Git commit 3dad378eda7478bb61d302ede902e5f807f46580 by Maik Qualmann.
Committed on 10/04/2018 at 16:49.
Pushed by mqualmann into branch 'master'.

add virtual bookmark root folder
FIXED-IN: 6.0.0

M  +2    -1    NEWS
M  +16   -5    core/utilities/geolocation/editor/bookmark/bookmarknode.cpp
M  +3    -2    core/utilities/geolocation/editor/bookmark/bookmarknode.h
M  +14   -3    core/utilities/geolocation/editor/bookmark/bookmarksdlg.cpp
M  +5    -1    core/utilities/geolocation/editor/bookmark/bookmarksmenu.cpp
M  +8    -3    core/utilities/geolocation/editor/bookmark/bookmarksmngr.cpp

https://commits.kde.org/digikam/3dad378eda7478bb61d302ede902e5f807f46580