Bug 391327 - Saving passwords doesn't work on some sites
Summary: Saving passwords doesn't work on some sites
Status: CONFIRMED
Alias: None
Product: Falkon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
: 391347 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-03-03 09:13 UTC by Petro
Modified: 2021-01-29 15:30 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petro 2018-03-03 09:13:30 UTC
I'm using KDE Neon with plasma 5.12.2 and QT 5.10

When entering login and password on website Falkon doesn't keep the data it even do not ask about it if the data shall be kept. That happens with all set up variation in password manager and also with kwallet which bothers me the most.

However the way to solve this, as workaround is to change user agent to Opera.
Comment 1 David Rosca 2018-03-03 09:23:42 UTC
Please provide some url where do you have this issue.
Comment 2 Petro 2018-03-03 10:04:11 UTC
it works with:

mail.yahoo.com
poczta.o2.pl
bugs.kde.org

Do not work with:

google.com (works only as opera)
youtube.com (works only as opera)
outlook.live.com/owa (do not work at all)
allegro.pl (Falkon remembers login and password with next attempt Falkon fills data in the form correctly but form it self states: please enter login and password which are in the form however there is need to ender data again)

With Firefox all remembered login and passwords with that www sites works OK.
Comment 3 David Rosca 2018-03-03 13:27:10 UTC
Google (accounts.google.com) is sending <form> that has no inputs. When you change user-agent to Opera, it loads older version of sign-in form that is more sane and actually have inputs, so the detection works in this case.
Outlook seems to not even send the <form>.

I'm not really sure what to do in these cases, as it seems to be impossible to detect currently. To do so, it would be needed to intercept the outgoing POST data, which is currently not possible in QtWebEngine.

allegro.pl requires "change" event to be sent when changing value of inputs, which Falkon is currently not doing. I will fix this one.
Comment 4 David Rosca 2018-03-03 13:34:18 UTC
Git commit 30b2ba41cd9acb2b415e22ab0907981a29b27fd7 by David Rosca.
Committed on 03/03/2018 at 13:28.
Pushed by drosca into branch 'Falkon/3.0'.

Scripts: Send change event when changing input value in completeFormData

Fixes incorrectly completing form data on some sites.

M  +3    -1    src/lib/tools/scripts.cpp

https://commits.kde.org/falkon/30b2ba41cd9acb2b415e22ab0907981a29b27fd7
Comment 5 Petro 2018-03-03 18:31:44 UTC
I do not know much about how it's done in chromium(which also uses Kwallet) However what i can see in kwallet and logs for chromium they describe to the particular address all accounts(logins and passwords) they do not separate site login password.
Comment 6 David Rosca 2018-03-03 19:05:37 UTC
*** Bug 391347 has been marked as a duplicate of this bug. ***
Comment 7 Ed Silkworth 2019-02-06 17:43:34 UTC
Saving passwords doesn't work on sites like seamless.com, ticketmaster.com, netflix.com, hulu.com, etc., either.

Falkon 3.0.0
Kubuntu 18.04.1 LTS

I tried Falkon 3.0.1 too, via Snap, but had the same problem.
Such a fun browser, but saving passwords and autofill cripple it for me.
Comment 8 Ed Silkworth 2019-02-06 17:57:13 UTC
I only mentioned netflix.com and hulu.com because, perhaps, they share similarities with seamless.com, ticketmaster.com, as well as opentable.com, spectrum.net, chase.com, etc. Sities on which saving passwords doesn't work.
Comment 9 David Rosca 2019-03-14 10:37:31 UTC
If the site doesn't use classic HTML form or it does some client-side password hashing implementation in Falkon will unfortunately not work.
There is no proper API in QtWebEngine, so at the moment there is not much to do.
Comment 10 Ed Silkworth 2019-03-14 19:42:58 UTC
i see, (In reply to David Rosca from comment #9)
> If the site doesn't use classic HTML form or it does some client-side
> password hashing implementation in Falkon will unfortunately not work.
> There is no proper API in QtWebEngine, so at the moment there is not much to
> do.

ah! I see, makes sense
thank you for sharing
Comment 11 Jan Przybylak 2019-04-14 09:44:30 UTC
What about an option in the right-click menu? If detecting is currently not possible on some sites, I think that would be a viable workaround.
Comment 12 Martin 2021-01-26 22:06:35 UTC
Same issue with
CarouselL.com.my
Works with Firefox, Edge but not Falkon
Carousell pops up a picture captcha before continuing to login. Might be relevant, do not know.
It would help, to be able to create password entries in settings then we can see if it is both ends of the detection process that fail.
Thanks for the hard workπŸ‘
Comment 13 Martin 2021-01-27 22:33:01 UTC
This is a barrier to entry for new users.
A work around is fine for those that come here but to the average user it will be:
1 install
2 go to favoured site
3 password does not save
4 uninstall and try something else

I think this issue needs some study. Since Google have and need Chrome they can keep people on Chrome by breaking the password helper (typical MBA level scam). So this issue may need some ongoing testing and resources.

Importance should be above normal, if you want the average person to use Falkon,

Just my opinion.
Sorry that I do not have the skill base to fix it.