Bug 391300 - Save Page As.. defaults to home directory
Summary: Save Page As.. defaults to home directory
Status: RESOLVED FIXED
Alias: None
Product: Falkon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-02 15:08 UTC by Jonathan Riddell
Modified: 2018-05-12 11:30 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 3.0.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Riddell 2018-03-02 15:08:47 UTC
Right click -> Save Page As... save defaults to home directory.  I was expecting it to default to Downloads.

(I'm also not convinced that mime html archive is the expected format to save in, I was just hoping to save as the single page by default especially as I was looking at a text file)
Comment 1 David Rosca 2018-03-31 10:18:36 UTC
Git commit 94e1421d3086ca031ccaf568dc2bb1224fc55cd0 by David Rosca.
Committed on 31/03/2018 at 08:26.
Pushed by drosca into branch 'Falkon/3.0'.

DownloadManager: Set default download path to Downloads folder
FIXED-IN: 3.0.1

M  +1    -1    src/lib/downloads/downloadmanager.cpp

https://commits.kde.org/falkon/94e1421d3086ca031ccaf568dc2bb1224fc55cd0
Comment 2 David Rosca 2018-03-31 10:18:36 UTC
Git commit 93af3896ee8a1344601344a5878d82dee813248d by David Rosca.
Committed on 31/03/2018 at 10:17.
Pushed by drosca into branch 'Falkon/3.0'.

WebView: Use direct url download when contents is not web page

Directly download file when contents is not a web page, eg. image,
text file, video, ...

Requires building against QtWebEngine 5.10.

M  +14   -0    src/lib/webengine/webview.cpp

https://commits.kde.org/falkon/93af3896ee8a1344601344a5878d82dee813248d
Comment 3 Kevin Kofler 2018-05-12 11:30:30 UTC
Git commit d06a0d60e0ff3e9e3d5dbaec17b3447fca665b92 by Kevin Kofler.
Committed on 12/05/2018 at 11:29.
Pushed by kkofler into branch 'Falkon/3.0'.

Fix the fix for #391300 to require only QtWebEngine 5.10, not Qt 5.10

QtWebEngine can be newer than the rest of Qt (e.g., on Fedora 27).

This fixes the version check in WebView::savePageAs to use a macro
defined in config.h.cmake based on the version of QtWebEngineWidgets
rather than relying on QT_VERSION, which is the version of QtCore.

Reviewed By: drosca
Differential Revision: https://phabricator.kde.org/D12833

M  +2    -0    CMakeLists.txt
M  +3    -0    config.h.cmake
M  +1    -1    src/lib/webengine/webview.cpp

https://commits.kde.org/falkon/d06a0d60e0ff3e9e3d5dbaec17b3447fca665b92