Bug 391283 - Changed and Accessed columns appear when switching from v2.6.0 to git version
Summary: Changed and Accessed columns appear when switching from v2.6.0 to git version
Status: RESOLVED UPSTREAM
Alias: None
Product: krusader
Classification: Applications
Component: general (show other bugs)
Version: Git
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-02 08:30 UTC by Nikita Melnichenko
Modified: 2018-05-06 00:15 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Melnichenko 2018-03-02 08:30:26 UTC 
I see the columns were introduced in 68a1889b56a7d0c4f856447bac79ed141b343391 along with the code:

+        // do not show new columns by default; restoreState() shows columns not saved
+        if (KrGlobal::sCurrentConfigVersion < KrGlobal::sConfigVersion) {
+            hideColumn(KrViewProperties::Changed);
+            hideColumn(KrViewProperties::Accessed);
+        }

I checked that even though hideColumn lines are executed, the columns are still visible.
Comment 1 Nikita Melnichenko 2018-03-24 06:42:32 UTC 
Steps to repro:
1. Backup your ~/.config/krusaderrc
2. Edit ~/.config/krusaderrc:
- Remove line: Config Version=1
- Modify line Version= to be: Version=2.6.0
3. Checkout v2.6.0-master and build.
4. Open and close krusader.
5. Checkout master and build.
6. Open: you should see the columns.

Please confirm when time allows. Thanks!
Comment 2 Nikita Melnichenko 2018-03-30 06:24:46 UTC 
Ping. I ask to confirm for a reason: if it's an issue on my end only, then I don't care; if it's happening for everyone upgrading from old version, then it's an annoying bug and I'll try to fix it before release.
Comment 3 Martin Kostolný 2018-03-30 20:46:33 UTC 
Sorry, I totally forgot about this.

I have definitely experienced this problem once in the past. But I'm now unable to replicate that anymore. I've also followed your STR but the new columns did not show up.
Comment 4 Nikita Melnichenko 2018-04-03 07:51:38 UTC 
Thanks for testing, Martin. Let's consider this as not important for the release then.
Comment 5 Nikita Melnichenko 2018-04-19 06:11:20 UTC 
After upgrade to Qt 5.9 I'm no longer able to repro. Seems to be an upstream issue. Closing.