Bug 391273 - Crashed when dragging several keyframes around
Summary: Crashed when dragging several keyframes around
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: 4.0.0-beta.1
Platform: Other Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-02 00:46 UTC by Sam Hagin
Modified: 2018-05-10 21:59 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Crash while animating (19.90 KB, text/plain)
2018-03-02 00:46 UTC, Sam Hagin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Hagin 2018-03-02 00:46:13 UTC
Created attachment 111123 [details]
Crash while animating

Crashed when dragging several keyframes around. Also, when I restarted Krita and created the animation it would not play it correctly. It would skip over keyframes until it reached the end of the animation set which was 33 frames then do the animation in half a sec as if I set keyframes up one after another. When I moved the keyframes around to make the animation take longer it did the same thing but the image would also blink.
Comment 1 Scott Petrovic 2018-03-25 17:22:00 UTC
I have heard a few reports for moving animation keyframes causing issues. This can be the ticket to track that issue.

I haven't seen a reproducible way to get this, but it is not uncommon.
Comment 2 Bollebib 2018-04-04 14:42:50 UTC
i often have this too but i dont know why,sometimes i cazn move many frames no issue

sometimes i move a few,and crash.
Comment 3 Halla Rempt 2018-04-28 11:16:14 UTC
Dmitry, can you take a look?
Comment 4 Scott Petrovic 2018-05-10 21:59:03 UTC
I am pretty sure this is fixed as part of this commit by Dmitry... marking resolved unless someone can prove me wrong.


Author:		Dmitry Kazakov <dimula73@gmail.com>
Author date:	4 days ago (5/6/2018 6:47:45 AM)
Commit date:	4 days ago (5/6/2018 7:02:33 AM)
Commit hash:	b6c39175b43c5f7a2d6613019fab4bbcd31f3302

Fix copy-paste frames operation when the timeline layout changes

Now "application/x-krita-frame" mime type also saves the UUID of the
source node, so pasting the frames after the row layout changed is still
valid.

The patch also implements a new version of
KisAnimationUtils::createMoveKeyframesCommand which is safe to use
when the frame moves have cyclic dependencies (one frame is going to
overwrite another frame during the move). Theoretically, we don't need
to use sortPointsForSafeMove() anymore. But it should be tested.

Contained in branches: master
Contained in no tag