Bug 391188 - First paragraph of Description inappropriately displayed as Comment
Summary: First paragraph of Description inappropriately displayed as Comment
Status: RESOLVED NOT A BUG
Alias: None
Product: Discover
Classification: Applications
Component: KNewStuff Backend (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL: https://phabricator.kde.org/T8137
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-27 23:21 UTC by Nate Graham
Modified: 2018-03-02 23:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Comparison between Discover and store.kde.org: Description displayed inappropriately (726.63 KB, image/png)
2018-02-27 23:21 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-02-27 23:21:38 UTC
Created attachment 111070 [details]
Comparison between Discover and store.kde.org: Description displayed inappropriately

See attached screenshot. The first paragraph becomes the Comment, which is inappropriate for a variety of reasons:
- It wasn't meant to be displayed this way
- If it's long, it will get elided and look ugly
- If there's only one paragraph, nothing is displayed in Discover's Description section, as shown in the screenshot
Comment 1 Aleix Pol 2018-03-02 15:26:01 UTC
That happens because many resources don't fill in the short summary.
We did get bug reports because it was empty and the delegate looked b0rked, so we added such fallback. See KNSResource::comment().

To me the solution is to get hold of the store.kde.org and make sure resources offer the text fields we need.
Comment 2 Nate Graham 2018-03-02 20:50:51 UTC
Is the short summary/comment field not mandatory for KNS items? If it isn't, we should consider making it mandatory, because otherwise clients like Discover are going to display ugly-mis-formatted content forever. Perhaps we should discuss this on https://phabricator.kde.org/project/view/70/?
Comment 3 Nate Graham 2018-03-02 20:53:14 UTC
Er, I mean https://phabricator.kde.org/T8137

Until that's changed (or if it's declined), perhaps we should simply omit the Comment field in Discover for resources that don't provide that information. Trying to synthesize it artificially leads to bad-looking results.
Comment 4 Aleix Pol 2018-03-02 23:37:45 UTC
What I was trying to tell you is that we used to omit it, it also looked bad.
At the moment, anything we do will look bad so I prefer not to spend time on it until it's not fixed in our main provider.
Comment 5 Nate Graham 2018-03-02 23:42:32 UTC
Hmm, it's hard for me to imagine that omitting the comment could possibly look worse than jamming the entire description into the comment, losing most of it because of eliding, and having no description at all.

But I agree that the data source should be improved. Let's focus on that.