Bug 391180 - Device notifier shows "This device can now be safely removed" when a removable device is mounted
Summary: Device notifier shows "This device can now be safely removed" when a removabl...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Disks & Devices (show other bugs)
Version: 5.12.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-27 18:38 UTC by Patrick Silva
Modified: 2018-03-20 11:51 UTC (History)
3 users (show)

See Also:
Latest Commit: https://commits.kde.org/plasma-workspace/f449adc1993626f1dc7e9216068ab6778e397782
Version Fixed In: 5.12.4

Attachments
demonstration (368.33 KB, image/gif)
2018-02-27 18:38 UTC, Patrick Silva 		Details
Don't ever emit "can be safely removed" when mounting (625 bytes, patch)
2018-03-19 10:43 UTC, Kai Uwe Broulik 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-02-27 18:38:45 UTC 
Created attachment 111062 [details]
demonstration

insert a cd/dvd/bd and mount it
connect a pendrive to your usb port and mount it
when the pendrive is mounted, device notifier shows "This device can now be safely removed".
See my gif.
Comment 1 Germano Massullo 2018-03-17 16:52:28 UTC 
It is not related to a second removable device. It happens with any removable device
Comment 2 Patrick Silva 2018-03-17 19:33:45 UTC 
(In reply to Germano Massullo from comment #1)
> It happens with any removable device

you are right.
Comment 3 Kai Uwe Broulik 2018-03-19 10:43:26 UTC 
Created attachment 111493 [details]
Don't ever emit "can be safely removed" when mounting
Comment 4 Kai Uwe Broulik 2018-03-19 10:43:35 UTC 
Can you try this patch?
Comment 5 Germano Massullo 2018-03-20 07:24:16 UTC 
(In reply to Kai Uwe Broulik from comment #3)
> Created attachment 111493 [details]
> Don't ever emit "can be safely removed" when mounting

The patch fixed the problem. Tested on Fedora 27
Comment 6 Kai Uwe Broulik 2018-03-20 11:51:17 UTC 
Git commit f449adc1993626f1dc7e9216068ab6778e397782 by Kai Uwe Broulik.
Committed on 20/03/2018 at 11:50.
Pushed by broulik into branch 'Plasma/5.12'.

[DeviceNotifications Engine] Never show safely remove message when mounting

It doesn't make any sense.
FIXED-IN: 5.12.4

Differential Revision: https://phabricator.kde.org/D11504

M  +1    -1    dataengines/devicenotifications/ksolidnotify.cpp

https://commits.kde.org/plasma-workspace/f449adc1993626f1dc7e9216068ab6778e397782