I'm implementing a plasmoid that would show which lock keys are currently locked. For Caps Lock we have "input-caps-on", it would be interesting to have an icon for the "Num Lock". Thanks!!
Git commit e2c9a044e51220cf4488bd449c2e963c68c88df1 by Aleix Pol. Committed on 27/02/2018 at 00:18. Pushed by apol into branch 'master'. At least show an awkward overlay for numlock At least until we have a proper icon M +8 -1 applets/keyboardindicator/contents/ui/main.qml https://commits.kde.org/kdeplasma-addons/e2c9a044e51220cf4488bd449c2e963c68c88df1
Do you want a new icon or a existing one? If you want an existing one, what kind of color do you want and in which size do you want it?
Thus bug is requesting a new one. Since it's a status icon, the typical 16px and 22px status icon sizes would be nice. Are you planning to work on this? That would be nice too. :)
Okay, thanks! I will see what I can do. I am a beginner in this and I'm looking forward to improve my skills!
Is this the "input-caps-on"?:https://github.com/KDE/breeze-icons/blob/master/icons-dark/status/22/input-caps-on.svg
That's for caps lock, not num lock. :) The requested icon should basically be like that, only with a number in it instead of a letter.
Great! Just let us know in the VDG channel/room if you need a hand.
Okay, I have a .svg file with an icon how should I upload it?
(In reply to Arvid Hansson from comment #8) > Okay, I have a .svg file with an icon how should I upload it? This wiki page explains how to contribute patches: https://community.kde.org/Infrastructure/Phabricator Feel free to ask questions on #kde-vdg (Freenode IRC), #kde-vdg:kde.org on Matrix ( https://riot.im/app/#/room/#kde-vdg:kde.org ) or the KDE VDG room on Telegram ( https://telegram.me/vdgmainroom )
Specifically, in this case you don't submit a new icon, you edit the original file, since we're talking about an svgz file that actually contains multiple icons inside it (svgz files are a bit weird, I know...). You change the original svgz file in your local clone of the plasma-framework git repo, and then you follow these instructions to submit it: https://community.kde.org/Get_Involved/development#Submit_a_patch
Okay. First of all I don't have my computer right now, I will investigate further tomorrow. Second I don't have a .svgz file, just a .svg file I made from Inkscape. Is there any way to convert it? I think the submitter should be Aleix Pol who needs an icon for his project. I just help with the icon, I need to send my first icon to him/she and get some feedback. Thanks for helping me with this as I'm very new to this!
(In reply to Arvid Hansson from comment #11) > Okay. First of all I don't have my computer right now, I will investigate > further tomorrow. Second I don't have a .svgz file, just a .svg file I made > from Inkscape.Is there any way to convert it? Just copying and pasting from one Inkscape document to another should work. I know this is kind of awkward, sorry. In the future, when you're making a new icon for the Breeze *icon* theme (as opposed to the icons in the Breeze *Plasma* theme), then you will indeed create a whole new file and submit that. But for the Breeze Plasma theme, it uses these combined svgz files that each contain multiple icons, so when adding a new one, you put it next to the existing icons already in the file. > I think the submitter should > be Aleix Pol who needs an icon for his project. I just help with the icon, I > need to send my first icon to him/she and get some feedback. Thanks for > helping me with this as I'm very new to this! That's not exactly the way it works. :) Since you've made the icon, you get to submit it and claim all the credit once it lands! Aleix will be one of the patch's reviewers once it's submitted (along with the rest of the KDE VDG team).
(In reply to Nate Graham from comment #12) > (In reply to Arvid Hansson from comment #11) > > Okay. First of all I don't have my computer right now, I will investigate > > further tomorrow. Second I don't have a .svgz file, just a .svg file I made > > from Inkscape.Is there any way to convert it? > > Just copying and pasting from one Inkscape document to another should work. > I know this is kind of awkward, sorry. In the future, when you're making a > new icon for the Breeze *icon* theme (as opposed to the icons in the Breeze > *Plasma* theme), then you will indeed create a whole new file and submit > that. But for the Breeze Plasma theme, it uses these combined svgz files > that each contain multiple icons, so when adding a new one, you put it next > to the existing icons already in the file. Okay I think I get it, but the icon is only a example, I'm not expecting it to be the final version. I want to co-operate with others to get it perfect. > > I think the submitter should > > be Aleix Pol who needs an icon for his project. I just help with the icon, I > > need to send my first icon to him/she and get some feedback. Thanks for > > helping me with this as I'm very new to this! > > That's not exactly the way it works. :) Since you've made the icon, you get > to submit it and claim all the credit once it lands! Aleix will be one of > the patch's reviewers once it's submitted (along with the rest of the KDE > VDG team). Yes, but if I publish it, will Aleix Pol get access to it so he/she can add it into his/her project?
(In reply to Arvid Hansson from comment #13) > Okay I think I get it, but the icon is only a example, I'm not expecting it > to be the final version. I want to co-operate with others to get it perfect. That's exactly what the review process is for. :) You submit it, get feedback, implement changes, get feedback again, and so on, until it's considered high enough quality to be committed to the repo so everyone can start using it. > Yes, but if I publish it, will Aleix Pol get access to it so he/she can add > it into his/her project? Yep! Once the new icon is accepted, it will be committed to the repo and become publicly available for all. BTW Aleix is a (male) senior KDE developer. The "@kde.org" email address provides a clue. :)
The patch is up! https://phabricator.kde.org/D19952
That patch never landed and we still don't have a numlock icon in the Breeze icon theme. We have an icon in the Plasma theme though.
This was opened originally for the keyboard indicator which uses the plasma theme. So it's there for what I needed it back then. Feel free to reopen if you think it should be in breeze icons too.
There hasn't been any demand, so I guess we don't need to.