Bug 391108 - static (???) drop shadow image is super pixely
Summary: static (???) drop shadow image is super pixely
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.43.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
Depends on:
Reported: 2018-02-26 16:12 UTC by Harald Sitter
Modified: 2019-04-25 13:48 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.58

screenshot of the problem (63.03 KB, image/png)
2018-02-26 16:12 UTC, Harald Sitter

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2018-02-26 16:12:31 UTC
Created attachment 111020 [details]
screenshot of the problem

See screenshot.

Previews in the download dialog have a forced drop shadow added. It's super low quality though and looks like borrowed from minecraft.
Comment 1 Nate Graham 2019-02-08 18:26:02 UTC
Confirmed, this looks awful.
Comment 2 Dan Leinir Turthra Jensen 2019-04-20 08:28:02 UTC
Hmm... It does look really terrible in general... An easy fix is super easy, of course, and really just needs doing (i'll have a patch up momentarily), but do we /want/ a less terrible looking shadow here? It'll take a touch of effort to get that to happen, and it'd be a shame to do so if we don't really want to have it anyway ;)
Comment 3 Dan Leinir Turthra Jensen 2019-04-25 10:07:41 UTC
Git commit e1f5782a85186cc61c5ad55faa33ad5fdae729a9 by Dan Leinir Turthra Jensen.
Committed on 25/04/2019 at 10:07.
Pushed by leinir into branch 'master'.

Remove pixelated border

In the before-times, drop shadows were considered vitally important on everything, and so it was introduced to KNewStuff's dialogues as well. It was, however, never done quite right, and it's making our dialogues look all silly. So, we remove it for now, and if we still want it, we can reintroduce them in a more modern fashion.

Test Plan:
Open the details dialogue of any knewstuff listing
Before patch: See pixelated (and weirdly positioned) pixelated border on all preview images
After patch: See no pixelated border

Reviewers: #knewstuff, ngraham, sitter, #vdg

Reviewed By: ngraham, #vdg

Subscribers: anthonyfieroni, mmustac, ndavis, kde-frameworks-devel, #knewstuff

Tags: #frameworks, #knewstuff

Differential Revision: https://phabricator.kde.org/D20693

M  +0    -4    data/CMakeLists.txt
D  +-    --    data/thumb_frame.png
M  +0    -4    src/ui/imagepreviewwidget.cpp
M  +0    -1    src/ui/imagepreviewwidget_p.h