Bug 391107 - knewstuff renders all screenshots as squares
Summary: knewstuff renders all screenshots as squares
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.43.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
: 401782 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-02-26 16:00 UTC by Harald Sitter
Modified: 2018-12-11 14:38 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot of a konsole theme squared up (150.07 KB, image/png)
2018-02-26 16:01 UTC, Harald Sitter
Details
actual konsole theme screenshot (from store) (145.98 KB, image/png)
2018-02-26 16:02 UTC, Harald Sitter
Details
wallpaper preview also squared up (260.11 KB, image/png)
2018-02-26 16:05 UTC, Harald Sitter
Details
some wallpapers are squared server-side (146.88 KB, image/png)
2018-02-26 16:08 UTC, Harald Sitter
Details
Thumbnails still squares (198.47 KB, image/png)
2018-03-16 13:38 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2018-02-26 16:00:19 UTC
For known reasons screenshots get rendered as squares regardless of their actual aspect ratio. It makes them incredibly ugly.
Comment 1 Harald Sitter 2018-02-26 16:01:53 UTC
Created attachment 111015 [details]
screenshot of a konsole theme squared up

https://store.kde.org/p/1216368
https://cn.pling.com/img/2/2/6/b/434f0eeedc80bfb1fe0e0a87d1dcbd77cc6d.png
Comment 2 Harald Sitter 2018-02-26 16:02:35 UTC
Created attachment 111016 [details]
actual konsole theme screenshot (from store)
Comment 4 Harald Sitter 2018-02-26 16:08:09 UTC
Created attachment 111018 [details]
some wallpapers are squared server-side

This is possibly the strangest thing to me. This image still has the square frame but I think is actually squared server-side (that's why it has two previews). The second preview is also squared by squeezing it into the frame.

https://store.kde.org/p/1217067
Comment 5 Harald Sitter 2018-02-26 16:10:33 UTC
My current theory is that the store (randomly?) generates previews that are squared and the client always assumes it gets square input. That too seems strange though. Why would you there be strain on the server to generate the squares and then send useless bytes to the client? And I mean, if that is the case it's still nonesense because that last wallpaper I posted has 2 previews and one is wrong regardless since it hasn't a square aspect ratio.
Comment 6 Dan Leinir Turthra Jensen 2018-03-16 11:31:43 UTC
It turns out this was a serverside issue (see the linked report, which has now been closed). Ronald fixed this by changing the default crop so the data now matches the request. Thanks for trawling through it and supplying screenshots and whatnot!
Comment 7 Nate Graham 2018-03-16 13:38:16 UTC
Created attachment 111439 [details]
Thumbnails still squares

OK, we're close! I can confirm that as of today, the actual full-size screenshots in Discover have their correct aspect ratios. But the thumbnails are still small and square (see attached screenshot). Is this on KNS, or Discover?
Comment 8 Nate Graham 2018-12-08 14:47:38 UTC
Got a report in Bug 401782 that this isn't fixed; re-opening.
Comment 9 Nate Graham 2018-12-08 14:47:52 UTC
*** Bug 401782 has been marked as a duplicate of this bug. ***
Comment 10 Dan Leinir Turthra Jensen 2018-12-11 13:50:26 UTC
It turns out the change was only ever applied to the full size previews, not the thumbnails. They are now also returned with the correct aspect ratio, and as soon as caches run out and refresh and whatnot, things should start to look right :) Please do the testy thing and give word if things appear to be sorted, and then we can close the bug (again) - leaving it open until it's confirmed it works for people other than me as this is all about remote resources :)
Comment 11 Nate Graham 2018-12-11 14:38:37 UTC
Good news: I can now see KNS entries in Discover with rectangular thumbnails! Looks like the change worked now.