Bug 391078 - Change trash-empty icon to user-trash when Breeze has new icon
Summary: Change trash-empty icon to user-trash when Breeze has new icon
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (other bugs)
Version First Reported In: 17.12.2
Platform: Kubuntu Linux
: NOR minor
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-26 02:32 UTC by Andrew Crouthamel
Modified: 2019-01-20 17:47 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/gwenview/118dcb14fba4d7bbd6caf3ee7c04bd052aa763d4
Version Fixed/Implemented In: 19.04.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Crouthamel 2018-02-26 02:32:32 UTC 
Change the following line, per the code comment, once Breeze has an acceptable monochrome HiDPI-compatible icon.

fileopscontextmanageritem.cpp:161
    //TODO: Change this to only user-trash once Breeze makes some icon changes to clarify on HiDPI systems
    mTrashAction->setIcon(QIcon::fromTheme("trash-empty", QIcon::fromTheme(("user-trash"))));
Comment 1 Shubham 2019-01-20 17:47:17 UTC 
Git commit 118dcb14fba4d7bbd6caf3ee7c04bd052aa763d4 by Shubham Jangra.
Committed on 20/01/2019 at 17:46.
Pushed by shubham into branch 'master'.

Use user-trash icon for Trash action

Summary:
FIXED-IN: 19.04.0

Test Plan:
Before:
{F6557553}

After (WITHOUT QT_SCALE_FACTOR=2 gwenview)
{F6557554}

(WITH QT_SCALE_FACTOR=2 gwenview)
{F6557555}

Reviewers: ngraham

Reviewed By: ngraham

Tags: #gwenview

Differential Revision: https://phabricator.kde.org/D18391

M  +1    -4    app/fileopscontextmanageritem.cpp

https://commits.kde.org/gwenview/118dcb14fba4d7bbd6caf3ee7c04bd052aa763d4