Bug 390998 - Make error messages more prominent (was "Ignore content in mountpoints")
Summary: Make error messages more prominent (was "Ignore content in mountpoints")
Status: RESOLVED FIXED
Alias: None
Product: Plasma Vault
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Ivan Čukić
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-24 09:06 UTC by Michael Heidelbach
Modified: 2018-04-10 21:41 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Heidelbach 2018-02-24 09:06:59 UTC
If possible, ignore content in vault mountpoints.
It is very likely that a '.directory' file ends up in there.
Comment 1 Ivan Čukić 2018-02-26 08:48:37 UTC
What do you mean by "ignore content in mountpoints"? You need to be a bit more verbose.
Comment 2 Michael Heidelbach 2018-02-27 10:28:29 UTC
(In reply to Ivan Čukić from comment #1)
> What do you mean by "ignore content in mountpoints"? You need to be a bit
> more verbose.

~/Vaults/MyVault
MyVault is not mounted.
$ touch ~/Vaults/MyVault/.directory
Try to mount MyVault. 
It refuses to do so because ~/Vaults/MyVault is not empty.
I think MyVault should mount nevertheless.
Comment 3 Ivan Čukić 2018-02-27 22:21:33 UTC
Oh, that. 

FUSE denies mounting in a non-empty directory.

And that is not something I'm willing to override. If this is allowed, the user might accidentally save a document in the mountpoint directory thinking the vault is open (since there are files in said directory).
Comment 4 Michael Heidelbach 2018-02-28 06:11:28 UTC
(In reply to Ivan Čukić from comment #3)
That is very convincing.

Please consider to make the refusal message more prominent. E.g. Above the password entry field and maybe in a different color. The way it is displayed now it is easy to confuse it with a comment to the password entry field.
Comment 5 Ivan Čukić 2018-02-28 16:17:29 UTC
That is a good idea. :)
Comment 6 Ivan Čukić 2018-04-10 21:41:50 UTC
Git commit efafd9dd52059ddfcf45ba0ae450c3cc5be5714c by Ivan Čukić.
Committed on 10/04/2018 at 21:41.
Pushed by ivan into branch 'master'.

Making the error message when opening the vault more prominent

M  +16   -3    kded/ui/mountdialog.cpp
M  +3    -0    kded/ui/mountdialog.h
M  +19   -28   kded/ui/mountdialog.ui

https://commits.kde.org/plasma-vault/efafd9dd52059ddfcf45ba0ae450c3cc5be5714c