Bug 390929 - Audio volume slider is out of position
Summary: Audio volume slider is out of position
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: 18.04.3
Platform: Archlinux Linux
: NOR minor
Target Milestone: ---
Assignee: Gwenview Bugs
Keywords: junior-jobs
Depends on:
Reported: 2018-02-22 22:31 UTC by Patrick Silva
Modified: 2018-08-05 07:16 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 18.08.0

screenshot (81.66 KB, image/png)
2018-02-22 22:32 UTC, Patrick Silva

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-02-22 22:31:47 UTC
See screenshot taken on neon dev unstable.
Comment 1 Patrick Silva 2018-02-22 22:32:19 UTC
Created attachment 110913 [details]
Comment 2 null 2018-02-23 22:59:50 UTC
Interesting. For me it jumps to the correct position as soon as I try to move the slider.

(Could be either JJ or very hard…)
Comment 3 Kavinda 2018-03-02 03:28:37 UTC
When you change the volume, boundingRect() of HudSlider seems to change for no reason at all. Perhaps it's related to QGraphicsWidget.
Comment 4 Nate Graham 2018-03-02 03:33:05 UTC
Would you be interested in submitting a patch, Kavinda? Our documentation for this can be found at:
- https://community.kde.org/Get_Involved/development
- https://community.kde.org/Infrastructure/Phabricator
Comment 5 Kavinda 2018-03-03 04:21:25 UTC
I would have if I could. I don't think it's a easy job.
Comment 6 Nate Graham 2018-08-05 04:11:56 UTC
Patch available at https://phabricator.kde.org/D14578
Comment 7 Peter Mühlenpfordt 2018-08-05 07:16:49 UTC
Git commit fec2cd8b655e06c6cbb624b32737651b5a45bc8c by Peter Mühlenpfordt.
Committed on 05/08/2018 at 07:14.
Pushed by muhlenpfordt into branch 'Applications/18.08'.

Fix video controls volume slider not vertically centered sometimes

The volume slider of the video controls overlay is sometimes not
centered vertically. This happens mostly on KDE Neon or if Gwenview
is started to show a video by commandline argument.
This is caused by calculating the slider and handle positions before
initializing the widget and therefore using wrong values. After the
first slider change this is correctly updated.
This patch delays the initialization of the slider to give the
overlay widget time to setup.
FIXED-IN: 18.08.0

{F6173671, size=full}

{F6173673, size=full}

Test Plan:
* Start Gwenview with video file as commandline argument
* Check that all sliders are vertically centered in controls overlay
* Check in current KDE Neon system

Reviewers: #gwenview, rkflx

Reviewed By: #gwenview, rkflx

Subscribers: rkflx

Differential Revision: https://phabricator.kde.org/D14578

M  +4    -1    lib/hud/hudslider.cpp