Bug 390903 - Some icons look pixelated when I increase display scale
Summary: Some icons look pixelated when I increase display scale
Status: RESOLVED FIXED
Alias: None
Product: kget
Classification: Applications
Component: UI (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KGet authors
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2018-02-22 13:49 UTC by Patrick Silva
Modified: 2018-02-24 16:12 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 17.12.3
Sentry Crash Report:


Attachments
toolbar (21.96 KB, image/png)
2018-02-22 13:49 UTC, Patrick Silva
Details
preferences window (44.42 KB, image/png)
2018-02-22 13:50 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-02-22 13:49:53 UTC
Created attachment 110897 [details]
toolbar

kget 2.95 on Arch Linux, my display scale is 1.2 under X11.

Some icons in toolbar, menus and preferences window are pixelated.
See screenshots.
Comment 1 Patrick Silva 2018-02-22 13:50:18 UTC
Created attachment 110898 [details]
preferences window
Comment 2 Nate Graham 2018-02-22 15:59:05 UTC
Likely needs Qt::AA_UseHighDpiPixmaps set in main.cpp. See Bug 388633.
Comment 3 Nate Graham 2018-02-24 14:47:32 UTC
Patch submitted: https://phabricator.kde.org/D10794
Comment 4 Nate Graham 2018-02-24 14:59:51 UTC
Huh, the commit hook script didn't work, how strange.
Comment 5 Andrius Štikonas 2018-02-24 15:03:12 UTC
(In reply to Nate Graham from comment #4)
> Huh, the commit hook script didn't work, how strange.

I think because the line didn't start with BUG:

Your commit message contains:
Summary: BUG: 390903
Comment 6 Wolfgang Bauer 2018-02-24 15:10:11 UTC
(In reply to Andrius Štikonas from comment #5)
> (In reply to Nate Graham from comment #4)
> > Huh, the commit hook script didn't work, how strange.
> 
> I think because the line didn't start with BUG:
> 
> Your commit message contains:
> Summary: BUG: 390903

Right, AFAIK arc adds this "Summary: ", so it breaks when the Summary only consists of "BUG: xxx".
Better write a sentence before that "BUG: xxx" line... ;-)
Comment 7 Nate Graham 2018-02-24 16:12:44 UTC
Thanks, I've updated https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch