Bug 390888 - Outline of window drawn outside of pager widget
Summary: Outline of window drawn outside of pager widget
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Pager widget (show other bugs)
Version: 5.10.5
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-22 07:23 UTC by argonel
Modified: 2018-03-28 04:52 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
pager on right screen's panel (1.15 KB, image/png)
2018-02-22 07:23 UTC, argonel
Details
second screenshot (862 bytes, image/png)
2018-02-22 07:24 UTC, argonel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description argonel 2018-02-22 07:23:49 UTC
Created attachment 110887 [details]
pager on right screen's panel

I use "Only the current screen" mode, and have two displays with three desktops. On any desktop, if I drag a window off the left edge of either display, the pager widget on that display will draw out of bounds of the current display's page box.

The first screenshot shows the window on both displays, and the pager on the right display shows the outline drawn over the Application menu.

The second screenshot shows the pager on the panel of the left monitor, with a window partially offscreen to the left on desktop 2, with the outline drawn over desktop 1's frame.
Comment 1 argonel 2018-02-22 07:24:58 UTC
Created attachment 110888 [details]
second screenshot
Comment 2 Eike Hein 2018-02-22 07:33:53 UTC
I'll fix this soon.
Comment 3 Kai Uwe Broulik 2018-02-22 07:49:43 UTC
clip: true and done?
Comment 4 Eike Hein 2018-02-22 07:52:21 UTC
No, this is is a different regression. Clip: true would cut off the left border of the window rect, but it's meant to be full-bordered on all sides.
Comment 5 Eike Hein 2018-03-28 04:52:34 UTC
Git commit 20bcc8f0501bb3cd368b03797c0bdea54de9f84b by Eike Hein.
Committed on 28/03/2018 at 04:51.
Pushed by hein into branch 'Plasma/5.12'.

Do clamping in the model and add missing lower bound check

Summary:
Clamping the window delegate size to stay within the desktop
rect was previously done in the QML code, but only for the
higher bound. This moves clamping into the C++ model and adds
a lower bound.

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10736

M  +2    -2    applets/pager/package/contents/ui/main.qml
M  +19   -7    applets/pager/plugin/windowmodel.cpp

https://commits.kde.org/plasma-desktop/20bcc8f0501bb3cd368b03797c0bdea54de9f84b