Bug 390801 - Width of "Date format" drop down is not enough to show selected option when my system language is pt-br
Summary: Width of "Date format" drop down is not enough to show selected option when m...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Digital Clock (show other bugs)
Version: 5.13.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2018-02-20 18:30 UTC by Patrick Silva
Modified: 2018-12-04 17:58 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.15.0


Attachments
screenshot (63.42 KB, image/png)
2018-02-20 18:30 UTC, Patrick Silva
Details
Dropdown is working (631.17 KB, image/png)
2018-11-07 22:27 UTC, João Netto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-02-20 18:30:39 UTC
Created attachment 110852 [details]
screenshot

See screenshot taken in plasma 5.12.1.
Comment 1 João Netto 2018-11-07 22:27:54 UTC
Created attachment 116166 [details]
Dropdown is working

Is this still a problem?

My dropdown works just fine in pt-br. It abbreviates only when the dropdown is not selected.
Comment 2 Nate Graham 2018-11-07 22:29:58 UTC
Your screenshot shows the same problem: the button itself is not wide enough to accommodate the text of the longest entry.

I'll fix this soon.
Comment 3 João Netto 2018-11-07 22:33:03 UTC
Since this is marked as a junior job, do you want any help? I can pick it up
Comment 4 Nate Graham 2018-11-07 22:35:03 UTC
It's not actually so easy after all, so I'm removing the keyword. I am planning to redo and modernize the entire layout of the Digital Clock settings window, which will fix this in the process. But thanks for the offer!
Comment 5 Marco Martin 2018-12-03 16:52:49 UTC
Git commit 39e812d57fd6a52e6c8596f823564a241d9ae696 by Marco Martin.
Committed on 03/12/2018 at 16:52.
Pushed by mart into branch 'master'.

Port digital clock settings to QQc2 and Kirigami

Summary:
use QQC2 and FormLayout for alignment

also, qqc2 combobox doesn't suffer from 390801 anymore

Test Plan: tried to set all the options

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17333

M  +78   -85   applets/digital-clock/package/contents/ui/configAppearance.qml

https://commits.kde.org/plasma-workspace/39e812d57fd6a52e6c8596f823564a241d9ae696