Bug 390800 - Breeze dark: digital clock icon is barely visible
Summary: Breeze dark: digital clock icon is barely visible
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: 5.13.5
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-20 18:20 UTC by Patrick Silva
Modified: 2019-01-21 18:10 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.55


Attachments
screenshot (31.58 KB, image/png)
2018-02-20 18:20 UTC, Patrick Silva
Details
barely visible icon in plasma panel and context menu of digital clock (30.28 KB, image/png)
2019-01-21 16:09 UTC, Patrick Silva
Details
Same icon in system settings > regional settings (21.47 KB, image/png)
2019-01-21 16:14 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-02-20 18:20:30 UTC
Created attachment 110851 [details]
screenshot

Visibility of the icon from digital clock tooltip is not good when breeze dark is in use. See screenshot.
Comment 1 Nate Graham 2018-02-20 21:57:47 UTC
Are all other tooltips affected, or just this one?
Comment 2 Nate Graham 2018-02-20 21:58:13 UTC
Sorry, never mind. I thought you were talking about the text; I can see that you mean the icon.
Comment 3 Patrick Silva 2019-01-21 16:08:25 UTC
Same thing in plasma 5.15 beta.

Added screenshot showing barely visible icon in the context menu of digital clock and in plasma panel when digital clock settings is open.

Operating System: Arch Linux 
KDE Plasma Version: 5.14.90
KDE Frameworks Version: 5.54.0
Qt Version: 5.12.0
Comment 4 Patrick Silva 2019-01-21 16:09:36 UTC
Created attachment 117598 [details]
barely visible icon in plasma panel and context menu of digital clock
Comment 5 Patrick Silva 2019-01-21 16:14:31 UTC
Created attachment 117599 [details]
Same icon in system settings > regional settings
Comment 6 Nate Graham 2019-01-21 18:10:59 UTC
Git commit 871dd742651b84e0dd098b7cfb90c81ed6fef8f8 by Nate Graham, on behalf of Rafael Brandmaier.
Committed on 21/01/2019 at 18:10.
Pushed by ngraham into branch 'master'.

Improve contrast of preferences-system-time

Summary:

FIXED-IN: 5.55

Add outline to the `preferences-system-time` icon to improve contrast with the Breeze-dark desktop theme.

The outline is a bit small in the context menu, but that's due to this 32px icon being used at 16px size. Perhaps an action icon like `clock` should be used there instead.

Test Plan:
`preferences-system-time`:
{F6560737}

Contrast with tooltip:
{F6560738}

Contrast in context menu:
{F6560739}

Reviewers: #vdg, ngraham, ndavis

Reviewed By: #vdg, ngraham, ndavis

Subscribers: ndavis, ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D18432

M  +1    -28   icons-dark/preferences/32/preferences-system-time.svg
M  +1    -28   icons/preferences/32/preferences-system-time.svg

https://commits.kde.org/breeze-icons/871dd742651b84e0dd098b7cfb90c81ed6fef8f8