Bug 390638 - Wayland - cannot change primary screen
Summary: Wayland - cannot change primary screen
Status: RESOLVED FIXED
Alias: None
Product: KScreen
Classification: Plasma
Component: kcm (show other bugs)
Version: 5.12.1
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Sebastian Kügler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-17 21:14 UTC by Kamil Piwowarski
Modified: 2018-02-23 08:57 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kamil Piwowarski 2018-02-17 21:14:12 UTC
On Wayland session in Plasma 5.12.1 I am not able to move panel to another screen using „primary screen” in KScreen. I can select screen but after apply nothing changes.
Comment 1 Sebastian Kügler 2018-02-20 16:53:55 UTC
The panel and primary screen have nothing to do with each other. You can move the panel using the panel controller.

Note: Primary screen is not a concept in Wayland, it's not even well defined in X11-based Plasma, so we're moving away from it.
Comment 2 Kamil Piwowarski 2018-02-20 17:38:17 UTC
It would be good to remove this select box on Wayland session :)
Comment 3 Sebastian Kügler 2018-02-21 18:24:22 UTC
I agree, we should hide the respective UI in this case:

https://phabricator.kde.org/D10723
Comment 4 Sebastian Kügler 2018-02-23 08:57:39 UTC
Git commit cd3b350e0225a3a1616804924420f86e39db50a1 by Sebastian Kügler.
Committed on 23/02/2018 at 08:57.
Pushed by sebas into branch 'master'.

hide primary display combo when not supported

Summary:
Some backends, for example the kwayland backend, do not support
setting the primary display. The backends already make their
feature set known so we can just hide it from the UI.

It's enough to hide it from the UI since setting it doesn't make
any difference, the libkscreen backend will simply ignore it
internally, so it's just honest to not show it.

Test Plan:
ran kscreen kcm on both, X11 and wayland platforms, combo
and label are shown and hidden as expected

Reviewers: #plasma, dvratil, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kpiwowarski, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10723

M  +4    -2    kcm/src/widget.cpp
M  +2    -0    kcm/src/widget.h

https://commits.kde.org/kscreen/cd3b350e0225a3a1616804924420f86e39db50a1