Bug 390605 - Several icons look pixelated when I increase display scale under X11
Summary: Several icons look pixelated when I increase display scale under X11
Status: RESOLVED FIXED
Alias: None
Product: ktorrent
Classification: Applications
Component: general (show other bugs)
Version: 5.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Joris Guisson
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2018-02-17 12:43 UTC by Patrick Silva
Modified: 2018-08-28 19:54 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
main window (82.09 KB, image/png)
2018-02-17 12:43 UTC, Patrick Silva
Details
preferences (113.32 KB, image/png)
2018-02-17 12:43 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-02-17 12:43:37 UTC
Created attachment 110744 [details]
main window

See my screenshots please.
Comment 1 Patrick Silva 2018-02-17 12:43:55 UTC
Created attachment 110745 [details]
preferences
Comment 2 Kai Uwe Broulik 2018-02-20 09:15:00 UTC
Most likely needs `QGuiApplication::setAttribute(Qt::AA_UseHighDpiPixmaps);` set in main.cpp - the same fix as Bug 388633.
Comment 3 Andrew Crouthamel 2018-02-20 16:23:05 UTC
Confirmed on my system. I submitted a patch (first one!) so hopefully it will show in here automatically at some point.

https://phabricator.kde.org/D10688
Comment 4 Nate Graham 2018-02-20 17:12:07 UTC
The special keyword "BUG: 390605" that you added in the Summary section of your patch (thanks!) shows up in the full commit message, which gets parsed by commit hooks, one of which will find the keyword and automatically close this bug.

Congratulations on your first patch! May it be the first of many. :)
Comment 5 Andrius Štikonas 2018-02-20 18:09:36 UTC
Git commit cbdbeeea1a92eda031ab1e4e62545ce055aed845 by Andrius Štikonas, on behalf of Andrew Crouthamel.
Committed on 20/02/2018 at 17:55.
Pushed by stikonas into branch 'master'.

Show high-resolution and vector logos properly in HighDPI mode

Take the device pixel ration into consideration when rendering the logo,
so it looks nice in HighDPI mode.

Reviewed By: stikonas, ngraham

TEST PLAN: Tested with SVG icons.

Differential Revision: https://phabricator.kde.org/D10688

M  +1    -0    ktorrent/main.cpp

https://commits.kde.org/ktorrent/cbdbeeea1a92eda031ab1e4e62545ce055aed845
Comment 6 Andrius Štikonas 2018-08-28 19:54:43 UTC
Git commit 4815ef01764dc6b14daac9f9630da4c3fa336786 by Andrius Štikonas, on behalf of Andrew Crouthamel.
Committed on 28/08/2018 at 19:27.
Pushed by stikonas into branch '5.1'.

Show high-resolution and vector logos properly in HighDPI mode

Take the device pixel ration into consideration when rendering the logo,
so it looks nice in HighDPI mode.

Reviewed By: stikonas, ngraham

TEST PLAN: Tested with SVG icons.

Differential Revision: https://phabricator.kde.org/D10688

M  +1    -0    ktorrent/main.cpp

https://commits.kde.org/ktorrent/4815ef01764dc6b14daac9f9630da4c3fa336786