On the brush editor, a simple clicking/selecting a parameter/option will change the preset status as modified, it seems random but mostly the ones that are already selected produce this behavior. The following video shows the issue. https://drive.google.com/file/d/1AtGZg8q4DyVXa8viqRw1XyqoPJ_mKjxa/view?usp=sharing
Git commit d26f9f9706f06e833d2f72f14c57c2bd78b310c8 by Scott Petrovic. Committed on 02/03/2018 at 18:09. Pushed by scottpetrovic into branch 'master'. M +11 -3 libs/ui/kis_categorized_list_model.h M +4 -2 libs/ui/kis_paintop_settings_widget.cpp M +20 -26 libs/ui/widgets/kis_categorized_list_view.cpp M +2 -6 libs/ui/widgets/kis_categorized_list_view.h M +2 -2 libs/ui/widgets/kis_cmb_composite.cc M +1 -1 libs/ui/widgets/kis_paintop_list_widget.cpp https://commits.kde.org/krita/d26f9f9706f06e833d2f72f14c57c2bd78b310c8
Git commit 489a854dd35961e6c8d1c17889f3976f5c4bb504 by Scott Petrovic. Committed on 02/03/2018 at 18:10. Pushed by scottpetrovic into branch 'krita/4.0'. (cherry picked from commit d26f9f9706f06e833d2f72f14c57c2bd78b310c8) M +11 -3 libs/ui/kis_categorized_list_model.h M +4 -2 libs/ui/kis_paintop_settings_widget.cpp M +20 -26 libs/ui/widgets/kis_categorized_list_view.cpp M +2 -6 libs/ui/widgets/kis_categorized_list_view.h M +2 -2 libs/ui/widgets/kis_cmb_composite.cc M +1 -1 libs/ui/widgets/kis_paintop_list_widget.cpp https://commits.kde.org/krita/489a854dd35961e6c8d1c17889f3976f5c4bb504
That bug should be fixed. Along with that fix, I also talked with some artists and made the "lock" status only available with a right click. It was previously done with double clicking, but that was accidentally done a lot, so you need to be more explicit now when setting the lock status.
This bug still happening for me on the master branch, exactly the same way as originally stated, on a clean install, build. Let me know if I should test it differently and whether to re-open or investigate further.
Never mind previous comment, rebuild and now everything is fixed :)