Bug 390571 - Mediaframe: Width of "Fill mode" drop down is not enough to show selected setting
Summary: Mediaframe: Width of "Fill mode" drop down is not enough to show selected set...
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: General (show other bugs)
Version: 5.15.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 360646 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-02-16 17:26 UTC by Patrick Silva
Modified: 2019-03-08 16:14 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.0


Attachments
screenshot (26.90 KB, image/png)
2018-02-16 17:26 UTC, Patrick Silva
Details
screenshot taken in plasma 5.13.2 (285.73 KB, image/png)
2018-07-05 20:13 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-02-16 17:26:30 UTC
Created attachment 110725 [details]
screenshot

See screenshot taken on Arch Linux.
Comment 1 Scott Harvey 2018-02-17 14:14:55 UTC
This is also present on my Kubuntu 17.10 system. Also, the description text for the various image display modes does not update as different options are chosen.
Comment 2 David Edmundson 2018-02-19 10:53:45 UTC
Git commit 5bf2d077895b18ef7f1380f076eb2a35dfea1afd by David Edmundson, on behalf of Scott Harvey.
Committed on 19/02/2018 at 10:53.
Pushed by davidedmundson into branch 'master'.

Fix ComboBox & mode description for image fill mode

Summary:

Reworked ConfigGeneral.qml to properly display ComboBox for image
fill modes, along with descriptive message explaining fill mode.

Changed default change interval (main.xml) to 10.0 instead of the
random-appearing 6.8 original.

(Minor) Capitalized "Frame" in plasmoid title as "Media Frame"

Reviewers: #plasma, mart, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10618

M  +1    -1    applets/mediaframe/package/contents/config/main.xml
M  +127  -95   applets/mediaframe/package/contents/ui/ConfigGeneral.qml
M  +1    -1    applets/mediaframe/package/metadata.desktop

https://commits.kde.org/kdeplasma-addons/5bf2d077895b18ef7f1380f076eb2a35dfea1afd
Comment 3 Patrick Silva 2018-02-26 01:03:11 UTC
*** Bug 360646 has been marked as a duplicate of this bug. ***
Comment 4 Patrick Silva 2018-05-01 19:32:07 UTC
This bug is back on Arch Linux after upgrade to plasma 5.12.5.
Comment 5 Nate Graham 2018-05-01 19:34:15 UTC
It was fixed in master, which means 5.12.x didn't get the fix. You'll have to wait until 5.13.0
Comment 6 Patrick Silva 2018-07-05 20:13:18 UTC
Created attachment 113786 [details]
screenshot taken in plasma 5.13.2

Bug persists in plasma 5.13.2.
Comment 7 Nate Graham 2019-03-05 18:41:20 UTC
Here's a patch: https://phabricator.kde.org/D19548
Comment 8 Nate Graham 2019-03-08 16:14:21 UTC
Git commit d0c5e541d7673fa445eb4ec0bf51dd0d6821c74a by Nate Graham.
Committed on 08/03/2019 at 16:14.
Pushed by ngraham into branch 'master'.

[Media frame] Modernize and improve settings window

Summary:
This patch modernizes the Media Frame's user interface by doing the following:
- Port to QQC2
- Port to Kirigami FormLayout style
- Adopt a more granular interface for choosing the slideshow interval
- Update some labels
FIXED-IN: 5.16.0

Test Plan:
Tested all features; everything still works

{F6660095, size=full}

Reviewers: #vdg, #plasma, filipf

Reviewed By: #vdg, filipf

Subscribers: filipf, plasma-devel

Tags: #plasma

Maniphest Tasks: T10586

Differential Revision: https://phabricator.kde.org/D19548

M  +151  -113  applets/mediaframe/package/contents/ui/ConfigGeneral.qml

https://commits.kde.org/kdeplasma-addons/d0c5e541d7673fa445eb4ec0bf51dd0d6821c74a