Bug 390569 - Discover sources list does not show repository name correctly
Summary: Discover sources list does not show repository name correctly
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.12.1
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
: 390570 397881 398585 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-02-16 16:57 UTC by Andrew Crouthamel
Modified: 2018-10-01 14:42 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.14.0


Attachments
Misnamed repo source (1.12 MB, image/png)
2018-02-16 16:57 UTC, Andrew Crouthamel
Details
Discover displays and what's in /etc/apt/sources.list.d/* (318.34 KB, image/png)
2018-02-22 19:11 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Crouthamel 2018-02-16 16:57:47 UTC
Created attachment 110723 [details]
Misnamed repo source

One of my default repos does not display correctly in Discover. It shows as ".", please see attached screenshot. Here is my /etc/apt/sources.list:

# deb cdrom:[Kubuntu 17.10 _Artful Aardvark_ - Release amd64 (20180105.2)]/ artful main multiverse restricted universe

# See http://help.ubuntu.com/community/UpgradeNotes for how to upgrade to
# newer versions of the distribution.
deb http://us.archive.ubuntu.com/ubuntu/ artful main restricted
# deb-src http://us.archive.ubuntu.com/ubuntu/ artful main restricted

## Major bug fix updates produced after the final release of the
## distribution.
deb http://us.archive.ubuntu.com/ubuntu/ artful-updates main restricted
# deb-src http://us.archive.ubuntu.com/ubuntu/ artful-updates main restricted

## N.B. software from this repository is ENTIRELY UNSUPPORTED by the Ubuntu
## team. Also, please note that software in universe WILL NOT receive any
## review or updates from the Ubuntu security team.
deb http://us.archive.ubuntu.com/ubuntu/ artful universe
# deb-src http://us.archive.ubuntu.com/ubuntu/ artful universe
deb http://us.archive.ubuntu.com/ubuntu/ artful-updates universe
# deb-src http://us.archive.ubuntu.com/ubuntu/ artful-updates universe

## N.B. software from this repository is ENTIRELY UNSUPPORTED by the Ubuntu 
## team, and may not be under a free licence. Please satisfy yourself as to 
## your rights to use the software. Also, please note that software in 
## multiverse WILL NOT receive any review or updates from the Ubuntu
## security team.
deb http://us.archive.ubuntu.com/ubuntu/ artful multiverse
# deb-src http://us.archive.ubuntu.com/ubuntu/ artful multiverse
deb http://us.archive.ubuntu.com/ubuntu/ artful-updates multiverse
# deb-src http://us.archive.ubuntu.com/ubuntu/ artful-updates multiverse

## N.B. software from this repository may not have been tested as
## extensively as that contained in the main release, although it includes
## newer versions of some applications which may provide useful features.
## Also, please note that software in backports WILL NOT receive any review
## or updates from the Ubuntu security team.
deb http://us.archive.ubuntu.com/ubuntu/ artful-backports main restricted universe multiverse
# deb-src http://us.archive.ubuntu.com/ubuntu/ artful-backports main restricted universe multiverse

## Uncomment the following two lines to add software from Canonical's
## 'partner' repository.
## This software is not part of Ubuntu, but is offered by Canonical and the
## respective vendors as a service to Ubuntu users.
# deb http://archive.canonical.com/ubuntu artful partner
# deb-src http://archive.canonical.com/ubuntu artful partner

deb http://security.ubuntu.com/ubuntu artful-security main restricted
# deb-src http://security.ubuntu.com/ubuntu artful-security main restricted
deb http://security.ubuntu.com/ubuntu artful-security universe
# deb-src http://security.ubuntu.com/ubuntu artful-security universe
deb http://security.ubuntu.com/ubuntu artful-security multiverse
# deb-src http://security.ubuntu.com/ubuntu artful-security multiverse

#VirtualBox
deb https://download.virtualbox.org/virtualbox/debian artful contrib


Current versions:
KDE Plasma Version: 5.12.1
KDE Frameworks Version: 5.43.0
Qt Version: 5.9.1
Kernel Version 4.13.0-32-generic
OS Type: 64-bit
Comment 1 Scott Harvey 2018-02-16 21:20:22 UTC
I can confirm that I also have a blank repo in my Discover settings list. 

Specs:
Kubuntu 17.10.1
Plasma 5.12.1
KDE Frameworks 5.43.0
Qt 5.9.1
Kernel: 4.15.3-041503-generic
Comment 2 Aleix Pol 2018-02-22 18:33:21 UTC
*** Bug 390570 has been marked as a duplicate of this bug. ***
Comment 3 Aleix Pol 2018-02-22 18:34:39 UTC
This is an issue in PackageKit aptcc. Contacted upstream to see what they can do about it.
Comment 4 Daniel Nicoletti 2018-02-22 18:51:38 UTC
What do you have in /etc/apt/sources.list.d ?
Because all theses entries are parsed fine by aptcc
Comment 5 Nate Graham 2018-02-22 19:11:29 UTC
Created attachment 110909 [details]
Discover displays and what's in /etc/apt/sources.list.d/*

Attaching a screenshot showing what Discover displays and what's in /etc/apt/sources.list.d/*
Comment 6 Daniel Nicoletti 2018-02-22 19:44:01 UTC
And there it is:
download.opensuse.org  and section "./" not sure there is something to fix, maybe showing the repo-id? or baming opensuse for their weird/maybe wrong repo line.
Comment 7 Andrew Crouthamel 2018-02-22 21:37:22 UTC
(In reply to Daniel Nicoletti from comment #4)
> What do you have in /etc/apt/sources.list.d ?
> Because all theses entries are parsed fine by aptcc

In regards to my original screenshot on Kubuntu 17.10:

andrew@andrew-XPS-13-9360:~$ cat /etc/apt/sources.list.d/
gns3-ubuntu-ppa-artful.list
gns3-ubuntu-ppa-artful.list.save
kubuntu-ppa-ubuntu-backports-artful.list
kubuntu-ppa-ubuntu-backports-artful.list.save
libreoffice-ubuntu-ppa-artful.list
libreoffice-ubuntu-ppa-artful.list.save
lutris.list
lutris.list.save
megasync.list
megasync.list.save
paulo-miguel-dias-ubuntu-pkppa-artful.list
paulo-miguel-dias-ubuntu-pkppa-artful.list.save
peek-developers-ubuntu-stable-artful.list
plasmazilla-ubuntu-releases-artful.list
plasmazilla-ubuntu-releases-artful.list.save
teamviewer.list
teamviewer.list.save
wireshark-dev-ubuntu-stable-artful.list
wireshark-dev-ubuntu-stable-artful.list.save

I found it. It's the lutris.list one for me. Ugh.

I'd like to request the more verbose method of listing repos, as stated in 390570 (which was marked as duplicate of this bug):

I'd like to recommend at least including the base domain name in the source description. So instead of:

Artful (contrib)

It would be:

Artful virtualbox.org (contrib)

This would work well for the default Ubuntu repos as well:

Artful updates (multiverse)

Would become:

Artful updates ubuntu.com (multiverse)

Or, put the base domain name first, whatever you think is best. Either way, it would be more descriptive, without cluttering the interface with the full URL like before.
Comment 8 Aleix Pol 2018-05-03 14:09:17 UTC
@Daniel there definitely is something to fix. I'd say that at least the domain should always be shown as to who is distributing the software and "." is never an acceptable description of the repository anyway.

I agree that apt semantics don't make it easy... :/
Comment 9 Alex Ander 2018-06-22 22:35:31 UTC
with only domain names shown, there will be a bunch of ppa.launchpad.net's by some users. 
I'm quite ok with full urls, like "http://ppa.launchpad.net/obsproject/obs-studio/ubuntu xenial InRelease". 
What about a letting user to decide, what he want to see shown?
Comment 10 Nate Graham 2018-09-13 19:31:51 UTC
*** Bug 398585 has been marked as a duplicate of this bug. ***
Comment 11 Nate Graham 2018-09-14 16:27:48 UTC
*** Bug 397881 has been marked as a duplicate of this bug. ***
Comment 12 Aleix Pol 2018-10-01 14:25:49 UTC
Git commit d725d754b92360583527de157910b18f6116cac4 by Aleix Pol.
Committed on 01/10/2018 at 14:24.
Pushed by apol into branch 'Plasma/5.14'.

Include the repository name for ubuntu ppa

M  +12   -1    libdiscover/backends/PackageKitBackend/PackageKitSourcesBackend.cpp

https://commits.kde.org/discover/d725d754b92360583527de157910b18f6116cac4
Comment 13 Andrew Crouthamel 2018-10-01 14:29:01 UTC
(In reply to Aleix Pol from comment #12)
> Git commit d725d754b92360583527de157910b18f6116cac4 by Aleix Pol.
> Committed on 01/10/2018 at 14:24.
> Pushed by apol into branch 'Plasma/5.14'.
> 
> Include the repository name for ubuntu ppa
> 
> M  +12   -1   
> libdiscover/backends/PackageKitBackend/PackageKitSourcesBackend.cpp
> 
> https://commits.kde.org/discover/d725d754b92360583527de157910b18f6116cac4

Awesome, thanks Aleix!