Bug 390527 - Add Ctrl+H as Alternative Shortcut for Alt+. to Toggle Show Hidden Files
Summary: Add Ctrl+H as Alternative Shortcut for Alt+. to Toggle Show Hidden Files
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-15 21:12 UTC by Michael Tunnell
Modified: 2018-02-18 22:04 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: KDE Applications 18.04


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Tunnell 2018-02-15 21:12:04 UTC
I am not suggesting a replacement but rather adding an alternative option so both Alt+. and Ctrl+H work. This mostly applies to Dolphin but I also suggest it for any dialog popups as well.

Ctrl+H is the most common shortcut used in Linux distros so this would make it available for those people switching to Plasma that expect it to be there.

File Managers that have Ctrl+H by default:
Nautilus, Caja, Nemo, Thunar, PCManFM, Pantheon Files, & Solus Files.

There currently is an alternative of "F8" but this is so uncommonly used I forgot this was a thing. So I suggest replacing F8 with Ctrl+H as the alternative.

Side Note: I much prefer Alt+. so this is suggestion is to improve on-boarding to Plasma, not related to my preference.
Comment 1 Nate Graham 2018-02-15 21:30:43 UTC
Submitted a patch for this: https://phabricator.kde.org/D10558
Comment 2 Nate Graham 2018-02-18 21:56:09 UTC
Git commit 164a54928e5e0bf24d758ab7eba98b2fe47cfc0c by Nathaniel Graham.
Committed on 18/02/2018 at 21:55.
Pushed by ngraham into branch 'master'.

Add Ctrl+H to the list of shortcuts for "show/hide hidden files"

Summary:

Like {D10558}, but for the file dialogs too, to maintain consistency.

Test Plan: Tested with Open and Save dialogs in Kate. New and old shortcuts all worked and correctly triggered showing and hiding hidden files

Reviewers: #frameworks, #dolphin, elvisangelaccio, markg

Reviewed By: markg

Subscribers: markg

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D10616

M  +1    -0    src/filewidgets/kdiroperator.cpp
M  +1    -6    src/filewidgets/kfilewidget.cpp

https://commits.kde.org/kio/164a54928e5e0bf24d758ab7eba98b2fe47cfc0c
Comment 3 Nate Graham 2018-02-18 22:02:19 UTC
Git commit b95cc59091f9b538f87b616b92e91d6aace0e1be by Nathaniel Graham.
Committed on 18/02/2018 at 22:02.
Pushed by ngraham into branch 'master'.

Also use standard keyboard shortcut for "show/hide hidden files"

Summary:
Use Ctrl+H as another keyboard shortcut to show and hide hidden files, as it is already the standard used in other GTK-based Linux file managers (Nautilus, Nemo, Caja, Thunar, Pantheon Files). This doesn't replace any existing shortcuts, so existing KDE users' muscle memory is retained.
FIXED-IN: KDE Applications 17.12.3

Test Plan:
- Ctrl+H now shows and hides hidden files
- Alt+. still works to do the same
- F8 still works to do the same
- Toolbar button still changes state appropriately when any of the three shortcuts are used

Reviewers: #dolphin, elvisangelaccio

Reviewed By: elvisangelaccio

Subscribers: emateli, elvisangelaccio

Differential Revision: https://phabricator.kde.org/D10558

M  +1    -1    src/views/dolphinviewactionhandler.cpp

https://commits.kde.org/dolphin/b95cc59091f9b538f87b616b92e91d6aace0e1be