Bug 390471 - suppression by specification of source-file line number
Summary: suppression by specification of source-file line number
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: 3.13.0
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Ivo Raisr
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-14 20:06 UTC by Jeff Frontz
Modified: 2018-06-26 04:39 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch against 3.14.0 src & doc to implement/document suppression-by-file (7.32 KB, patch)
2018-02-15 20:44 UTC, Jeff Frontz
Details
patch with NEWS updated (9.73 KB, patch)
2018-06-25 19:58 UTC, Ivo Raisr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Frontz 2018-02-14 20:06:58 UTC
Several years ago (2005), Joe Link submitted a patch to allow specification of line numbers in suppression expressions (https://sourceforge.net/p/valgrind/mailman/message/14023169/ )

[E.g., in Joe's words:

support for suppression entries such as:

{
    allocator
    Memcheck:Leak
    fun:_Znaj
    src:quick_allocator.hpp:97
}

{
    allocator
    Memcheck:Leak
    fun:_Znaj
    src:quick_allocator.hpp
}
]

According to Ivo Raisr, this patch was never incorporated (https://sourceforge.net/p/valgrind/mailman/message/36225028/ )

I've modified Joe's original patch to conform to the new[er] infrastructure in a copy of the 3.13.0 source.  I'm clueless as to how to go about submitting the changes for review (and potential inclusion).  Do I just attach a diff/patch file to this request?  Or should I try to integrate it with a private version of 3.14.0 first (and then attach a diff/patch)?  Or something else?
Comment 1 Nate Graham 2018-02-14 22:23:32 UTC
Thanks for your interest! Patches are submitted using phabricator.kde.org. This should tell you what you need to know: https://community.kde.org/Infrastructure/Phabricator
Comment 2 Tom Hughes 2018-02-14 22:50:55 UTC
No, valgrind does not use phabricator. Just attach the patch here.
Comment 3 Nate Graham 2018-02-14 22:51:52 UTC
My mistake, sorry.
Comment 4 Jeff Frontz 2018-02-15 20:44:29 UTC
Created attachment 110691 [details]
Patch against 3.14.0 src & doc to implement/document suppression-by-file
Comment 5 Jeff Frontz 2018-02-15 20:46:53 UTC
I'm not sure what the protocol is for creating test cases (I can't seem to get them to work in my environment) but if someone can give me a pointer, I'll do my best to create something.

I tested this on x86 linux (FC7); building required modification per https://bugs.kde.org/show_bug.cgi?id=390524
Comment 6 Ivo Raisr 2018-06-25 19:58:07 UTC
Created attachment 113569 [details]
patch with NEWS updated

Patch cleaned up. Tests still pending.
Comment 7 Ivo Raisr 2018-06-26 04:39:22 UTC
Fixed in changeset 410d736a9928f535e2591c9d5f32e8e0941f96d8.

https://sourceware.org/git/?p=valgrind.git;a=commitdiff;h=410d736a9928f535e2591c9d5f32e8e0941f96d8