Bug 390467 - Save as defaults to encrypted with no way to not encrypt
Summary: Save as defaults to encrypted with no way to not encrypt
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: file (show other bugs)
Version: 5.0.0
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-14 18:16 UTC by Jack
Modified: 2018-02-16 19:19 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.0.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2018-02-14 18:16:56 UTC
In fixing some other issues, I unzipped my kmy file, edited it, and opened the xml file.  When I then tried to "Save as," it warned about saving encrypted, which I do not want to do.  Encryption is NOT checked in the configuration dialog, but "Save as" just brings up the file selection dialog, with no place I can find to tell it NOT to save encrypted.  I'm sure this worked as expected in 4.8.x, but I don't actually remember the last time I had to "Save as" instead of just "Save."  For now. I can continue to edit and save the xml file, but at some point, I would like to go back to kmy.
Comment 1 Jack 2018-02-14 19:53:17 UTC
Same behavior with git head 5.0 branch.  However, there are a few things I missed with the initial report.

Even though I cancel the save, by clicking "No" at the encrypted save warning,
KMM actually does save the file unencrypted.  

So, I see two separate bugs, but both less important than it seemed at first.

1) there should be a way to tell KMM not to encrypt, either before you save at all, or on the save dialog.  I realize we cannot add anything to the Frameworks file select dialog, and popping up an separate dialog first could seem annoying.  However, if the KMM configuration is set to not encrypt, then it probably should not be made the default here, unless somehow explicitly requested.

2) on the warning pop-up
 a) the title (I just see "Store GPG enc...ed -- KMyMoney ?" is too wide for the window shown, and
 b) the buttons Yes and No might be correct for whether or not to save encrypted, but they do not indicate that saying "No" still saves unencrypted, it doesn't cancel the save, as I thought.

I have changed this to a wishlist instead of bug, although I'm not really sure what the best change would be.  (Perhaps as simple as changing the last sentence of the warning from "If unsuer, answer NO" to "If unsure, answer NO, and the file will be saved without encryption."
Comment 2 Thomas Baumgart 2018-02-16 19:19:37 UTC
Git commit 03831143604ffb5f49267fc5dfdde97bb7059866 by Thomas Baumgart.
Committed on 16/02/2018 at 19:19.
Pushed by tbaumgart into branch '5.0'.

Allow to select keys during File/Save As

Due to the change in the KDE file save dialog the additional widgets
could not be inserted dynamically into the dialog as we did in KDE4.
This has been solved by an additional dialog when GPG encryption has
been enabled in the settings and is available.
FIXED-IN: 5.0.1
GUI:

M  +1    -0    kmymoney/dialogs/CMakeLists.txt
M  +77   -88   kmymoney/dialogs/kgpgkeyselectiondlg.cpp
M  +15   -3    kmymoney/dialogs/kgpgkeyselectiondlg.h
A  +139  -0    kmymoney/dialogs/kgpgkeyselectiondlg.ui
M  +19   -89   kmymoney/kmymoney.cpp
M  +1    -6    kmymoney/kmymoney.h

https://commits.kde.org/kmymoney/03831143604ffb5f49267fc5dfdde97bb7059866