Bug 390424 - Reordering applications in the Application Dashboard favorites, launches applications
Summary: Reordering applications in the Application Dashboard favorites, launches appl...
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: Application Dashboard (show other bugs)
Version: 5.15.3
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
: 388552 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-02-14 05:19 UTC by Andrew Crouthamel
Modified: 2019-03-18 15:50 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Crouthamel 2018-02-14 05:19:24 UTC
Reordering applications in the favorites area of the Application Dashboard causes the application being dragged to launch, upon mouse button release. This happens for every application in the Favorites area. This action is contrary to normal UI behavior a user expects.

This is always reproducible.

KDE Plasma Version: 5.12.0
KDE Frameworks Version: 5.42.0
Qt Version: 5.9.3
Kernel Version 4.13.0-32-generic
OS Type: 64-bit
Comment 1 Nate Graham 2018-02-14 17:50:56 UTC
So nice to see some attention paid to the Application Dashboard. :)
Comment 2 Andrew Crouthamel 2018-02-14 18:23:55 UTC
(In reply to Nate Graham from comment #1)
> So nice to see some attention paid to the Application Dashboard. :)

I really like it, especially with a touchscreen (once that other patch comes my way).
Comment 3 Nate Graham 2018-02-27 16:01:50 UTC
Andrew, would you be able to test again with Plasma 5.12.2 or the upcoming 5.12.3? Eike's told me that this may/should have been fixed in one of those.
Comment 4 Patrick Silva 2018-02-27 16:10:07 UTC
I can confirm on Arch Linux, plasma 5.12.2.
However the problem is intermittent here.
Comment 5 Andrew Crouthamel 2018-02-27 16:13:33 UTC
(In reply to Nate Graham from comment #3)
> Andrew, would you be able to test again with Plasma 5.12.2 or the upcoming
> 5.12.3? Eike's told me that this may/should have been fixed in one of those.

Good point, I didn't think about that. When he pushed the fix for touchscreen tapping, that probably changed this behavior. I'll give 5.12.3 a test in a bit.
Comment 6 Andrew Crouthamel 2018-02-28 19:58:23 UTC
It looks like this is still an issue. I tested on Neon Dev Unstable just now (4:5.12.2+p16.04+git20180228.1209-0), it still opens apps upon mouse release.

One thing I did notice, was that if you release the mouse button while an icon is highlighted blue, it will launch. If you reorder favorites, but drag the mouse out of bounds, so the icon is no longer highlighted blue, it does not launch. You can even drag your mouse back onto the icon, after the blue highlight goes away, and it will not re-highlight.
Comment 7 Patrick Silva 2018-04-22 15:32:34 UTC
*** Bug 388552 has been marked as a duplicate of this bug. ***
Comment 8 Andrew Crouthamel 2018-09-05 12:09:39 UTC
I just tested this again on the following and it is intermittent (every second or so move).

KDE Plasma Version: 5.13.4
KDE Frameworks Version: 5.49.0
Qt Version: 5.11.1
Kernel Version 4.18.5
OS Type: 64-bit
Comment 9 Alexander Mentyu 2018-09-12 09:22:23 UTC
Sometimes application is launched after dragging also on Wayland
Comment 10 Thibaut FRANCOIS 2019-03-13 13:02:35 UTC
After draging, sometimes the application isn't launch, but each time after draging an application, the dashboard closes. So it's necessary to re-open the dashoard to continue to reordering the favorites, it's not at all practical in terms of behaviour.
Comment 11 Thibaut FRANCOIS 2019-03-13 15:25:38 UTC
(In reply to Thibaut FRANCOIS from comment #10)
> After draging, sometimes the application isn't launch, but each time after
> draging an application, the dashboard closes. So it's necessary to re-open
> the dashoard to continue to reordering the favorites, it's not at all
> practical in terms of behaviour.

To complete my report :
Operating System: KDE neon 5.15
KDE Plasma Version: 5.15.3
KDE Frameworks Version: 5.56.0
Qt Version: 5.12.0
Kernel Version: 5.0.1-050001-generic
OS Type: 64-bit
Comment 12 Nate Graham 2019-03-18 15:50:23 UTC
Git commit 0ecb1359eaca6f13cf103793fc238a9b8d76536f by Nate Graham, on behalf of Tranter Madi.
Committed on 18/03/2019 at 15:49.
Pushed by ngraham into branch 'master'.

[Application Dashboard] Improve mouse handler

Summary:
- Do not close Application Dashboard after dragging items

- Correct the `view` attached property to `GridView.view`

Test Plan: - Application Dashboard is not closed when dragging items in the Favorites column.

Reviewers: hein, ngraham, #plasma

Reviewed By: hein, ngraham, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19800

M  +14   -11   applets/kicker/package/contents/ui/ItemGridView.qml

https://commits.kde.org/plasma-desktop/0ecb1359eaca6f13cf103793fc238a9b8d76536f