Bug 390382 - In the Brush Settings Dropdown, the preset chooser shows the wrong viewmode to what it uses.
Summary: In the Brush Settings Dropdown, the preset chooser shows the wrong viewmode t...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2018-02-13 15:43 UTC by wolthera
Modified: 2019-05-10 08:43 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Video (467.61 KB, video/mp4)
2018-10-03 15:14 UTC, mvowada
Details

Note You need to log in before you can comment on or make changes to this bug.
Description wolthera 2018-02-13 15:43:49 UTC
If you go to the brush settings, then the presetchooser, and then go to the viewmode pop-up next to the brush engine drop down, you will find that the chooser isset to list mode while the UI element says it's in thumbnail mode.

The code that causes this is in kis_paintop_presets_popup.cpp at line 145, where it loads a value from the config that is also used by the other preset choosers.

I cannot fix this bug because I don't know what the intended behaviour is here.
Comment 1 Scott Petrovic 2018-02-13 16:51:08 UTC
I am not quite sure how you got it in that state. I cannot reproduce it on my Windows machine when I load it up.

Maybe there might be something out of sync with the different views. There are a few places that use that widget, and some of them are "synced".  If you clear your kritarc, does that fix it?
Comment 2 wolthera 2018-02-14 12:28:18 UTC
Git commit 3928c0453ebe655eaab525e2ec96858ae2c47611 by Wolthera van Hövell tot Westerflier.
Committed on 14/02/2018 at 12:27.
Pushed by woltherav into branch 'master'.

This is a bit slower, but at the least more correct(and I couldn't
reposition the layer any other way)

M  +3    -2    libs/libkis/Node.cpp

https://commits.kde.org/krita/3928c0453ebe655eaab525e2ec96858ae2c47611
Comment 3 wolthera 2018-02-14 12:29:30 UTC
Ack wrong one to close >_<
Comment 4 Julian Steinmann 2018-09-15 14:55:42 UTC
I cannot reproduce this behavior with Krita 4.2.0-alpha (commit a794d32), but I could have easily misunderstood something. What is meant with "the UI element says it's in thumbnail mode"?

Operating System: KDE neon Developer Edition
KDE-Plasma-Version: 5.13.90
Qt-Version: 5.11.1
KDE-Frameworks-Version: 5.51.0
Comment 5 Andrew Crouthamel 2018-10-03 03:33:34 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 mvowada 2018-10-03 15:14:18 UTC
(Ubuntu 14.04 - Krita 4.2.0-pre-alpha (git 278e429))
Hi, I can confirm the issue reported by #1 wolthera. Steps:

    1. fresh configs
    2. start
    3. edit brush settings > toggle showing presets (arrow on the left)
    4. display mode (button next to the engines dropdown)

Actual Results: while presets are listed in "details" view, the active checkbox says thumbnails.
Comment 7 mvowada 2018-10-03 15:14:54 UTC
Created attachment 115383 [details]
Video
Comment 8 Halla Rempt 2019-05-10 08:43:05 UTC
Git commit e686f952dfdcc46ee9ab478e6d476c60f0b0b413 by Boudewijn Rempt.
Committed on 10/05/2019 at 08:41.
Pushed by rempt into branch 'master'.

Initialize KisPresetSelectorStrip with the global viewmode

If we follow the global viewmode setting in KisPaintOpPresetsPopup,
then we should also initialize it according to that viewmode.

M  +2    -2    libs/ui/widgets/kis_preset_selector_strip.cpp

https://invent.kde.org/kde/krita/commit/e686f952dfdcc46ee9ab478e6d476c60f0b0b413