Bug 390349 - Move "Help" menu onto the GlobalDrawer (orsome other globally-available location) with an appropriate UI
Summary: Move "Help" menu onto the GlobalDrawer (orsome other globally-available locat...
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.12.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
Depends on:
Blocks: 389717
  Show dependency treegraph
Reported: 2018-02-12 23:01 UTC by Nate Graham
Modified: 2018-11-09 00:22 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.15.0


Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-02-12 23:01:10 UTC
This will remove it from the Settings page's header, which will let us put the window title there and rename it to be "Sources".
Comment 1 Aleix Pol 2018-03-02 15:35:53 UTC
Where would you put this, in master?

Would it make sense to move this menu as a context action in the featured page?
Comment 2 Nate Graham 2018-03-02 20:58:16 UTC
Honestly I'd add a real menu bar with a full "Help" menu. The issue is that this isn't really page-specific at all; it's global. No matter where we put it, if it's not globally-available, it's not really the right location.

As a next-best option, we could put it on the globalDrawer, which is our only other mostly-globally-visible UI element.
Comment 3 Aleix Pol 2018-03-02 23:42:07 UTC
After all the work we've done to save the work the banner used, I'm not wasting 50px of vertical space only to add a menu bar with just the one menu with 2 items.

They may be global, but they don't need to be accessible at all times.
Remember we are talking about "About Discover" and "Report a bug".
Comment 4 Thomas Pfeiffer 2018-11-08 16:31:10 UTC
Putting it in the global drawer makes perfect sense. As Nate said, it's not specific to any page, which is exactly what the global drawer is for.
Comment 5 Aleix Pol 2018-11-08 17:23:30 UTC
Git commit 078dd8e1096b307f44639e5c95d1dae7f1ca5039 by Aleix Pol.
Committed on 08/11/2018 at 17:18.
Pushed by apol into branch 'master'.

Move settings contextual menu into the drawer, under "Help"

M  +17   -0    discover/qml/DiscoverDrawer.qml
M  +0    -5    discover/qml/SourcesPage.qml