Bug 390333 - autotest vimode_completion fails in ktexteditor 5.43.0
Summary: autotest vimode_completion fails in ktexteditor 5.43.0
Status: RESOLVED FIXED
Alias: None
Product: frameworks-ktexteditor
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.43.0
Platform: Other Linux
: VHI normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-12 17:40 UTC by Rik Mills
Modified: 2018-04-08 08:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rik Mills 2018-02-12 17:40:28 UTC
This change:

https://cgit.kde.org/ktexteditor.git/commit/?id=2bed94b6d463fafbbcb38f68bef90bcf18124cc6

https://phabricator.kde.org/D10054

appears to cause ktexteditor to fail it's vimode_completion autotests.

From KDE CI: https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/35/testReport/junit/(root)/TestSuite/vimode_completion/

Same failure is also seen on Ubuntu archive autotests, where it blocks 5.43 from reaching -release and hence to users.
Comment 1 Dominik Haumann 2018-02-12 22:19:26 UTC
Indeed, we have to look into this asap. Sad that we did not notice this earlier!
Comment 2 Dominik Haumann 2018-02-13 21:57:07 UTC
Thanks for bugging me. We should have taken care of this ASAP.

It seems my attempt to fix it was successful, see:
https://phabricator.kde.org/R39:1a38adebb64e6e7d5acb756f68166d56d8ba0b72
Comment 3 Dominik Haumann 2018-02-13 21:58:15 UTC
Ah, what may be interesting to add: This was a bug in the *tests*, meaning that KTextEditor 5.43 is fine and can be released on your side. You can either disable the broken tests for you in your release, or integrate this patch that should fix the unit tests.
Comment 4 Rik Mills 2018-02-13 22:07:24 UTC
Thank you for the quick resolution of this :)