Bug 390319 - cannot cancel flatpaks update
Summary: cannot cancel flatpaks update
Alias: None
Product: Discover
Classification: Applications
Component: Updates (interactive) (show other bugs)
Version: 5.12.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
Depends on:
Reported: 2018-02-12 14:25 UTC by Patrick Silva
Modified: 2018-04-09 16:58 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-02-12 14:25:37 UTC
Nothing happens when I click "cancel" button during flatpaks update.
Comment 1 Nate Graham 2018-03-14 17:00:04 UTC
Confirmed, happens to me too on git master. Now the cancel button actually disables properly, reflecting that the transaction isn't cancellable--but it should be!
Comment 2 Aleix Pol 2018-03-20 00:18:31 UTC
I'm not sure what you are talking about. There's even a bug report by Dr Chapatin about a crash when cancelling.

Also it works on my system. I need more information. Providing the terminal output could help.
Comment 3 Patrick Silva 2018-03-20 00:42:32 UTC
(In reply to Aleix Pol from comment #2)
> There's even a bug report by Dr
> Chapatin about a crash when cancelling.
crash happens when the installation of a new flatpak package is canceled.
This report is about flatpak updates.
Comment 4 Nate Graham 2018-03-20 15:22:04 UTC
Can confirm that I can cancel Flatpak installation, but not updating.
Comment 5 Aleix Pol 2018-04-09 16:58:38 UTC
Git commit b3a85d494cf9283fbac4b65f6e179e11e4e46067 by Aleix Pol.
Committed on 09/04/2018 at 16:57.
Pushed by apol into branch 'Plasma/5.12'.

Infer cancellability of the StandardBackendUpdater

If it contains transactions that can be cancelled, allow cancelling.

M  +2    -1    libdiscover/resources/ResourcesUpdatesModel.cpp
M  +12   -2    libdiscover/resources/StandardBackendUpdater.cpp
M  +3    -0    libdiscover/resources/StandardBackendUpdater.h

Comment 6 Aleix Pol 2018-04-09 16:58:38 UTC
Git commit c690772105a1f3b662293742564051596851f271 by Aleix Pol.
Committed on 09/04/2018 at 16:29.
Pushed by apol into branch 'Plasma/5.12'.

Forward action enabled state into the button

Otherwise it would look like cancel was an option when it wasn't

M  +1    -0    discover/qml/UpdatesPage.qml