Bug 390286 - please update version of lensfun
Summary: please update version of lensfun
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Bundle-AppImage (show other bugs)
Version: 5.9.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-11 20:22 UTC by jon33040
Modified: 2018-07-05 12:04 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jon33040 2018-02-11 20:22:17 UTC
The version of lensfun in digikam-5.9.0-20180209T014824-x86-64.appimage doesn't include the Sony RX10M3. That was included in lensfun on 15th September 2017.

Please could you update the version of lensfun in the appimage to be more recent than this.
Comment 1 Maik Qualmann 2018-02-11 22:19:47 UTC
Install the lensfun-tools and run lensfun-update-data in the console. This installs the current database in the user directory.

Maik
Comment 2 caulier.gilles 2018-02-12 11:10:15 UTC
Maik,

Can we use this lensfun tool to update the database in the library as well.

I suspect that DT do it already, as i remember to see this topic in the past somewhere in a Lensfun forum...

Gilles
Comment 3 Maik Qualmann 2018-02-12 18:43:33 UTC
Gilles,

do you mean to run lensfun-update-date at the AppImage creation and copy the databases from the user directory to /usr/share/lensfun? But I think then it would be easier to use the git/master version away?

Maik
Comment 4 caulier.gilles 2018-02-12 18:47:07 UTC
yes exactly, for all the bundle.

The problem to use the git/master API is the non stabilized implementations. I already ask this question somewhere in Lensfun Forum, and it's not yet the best way to use the library...

Gilles
Comment 5 caulier.gilles 2018-02-26 08:16:15 UTC
Under linux, a python3 script can update the lens database locally :

[gilles@localhost apps]$ pwd
/mnt/devel/GIT/lensfun-0.3.2/apps
[gilles@localhost apps]$ ./lensfun-update-data
Info: root privileges needed for updating the system database.
Info: updating user DB in '/home/gilles/.local/share/lensfun/updates'
Reading http://lensfun.sourceforge.net/db/versions.json …
Reading http://wilson.bronger.org/lensfun-db/versions.json …
Successfully updated the database in /home/gilles/.local/share/lensfun/updates/version_1.

Gilles Caulier
Comment 6 jon33040 2018-03-04 08:31:59 UTC
When I did this, I got something subtly different ...

jon@whitestar:~/.local/share/lensfun/updates/version_2$ ls
6x6.xml                     compact-nikon.xml      contax.xml         mil-samsung.xml  rf-leica.xml            slr-pentax.xml     slr-tamron.xml
actioncams.xml              compact-olympus.xml    generic.xml        mil-samyang.xml  slr-canon.xml           slr-ricoh.xml      slr-tokina.xml
compact-canon.xml           compact-panasonic.xml  mil-canon.xml      mil-sigma.xml    slr-hasselblad.xml      slr-samsung.xml    slr-ussr.xml
compact-casio.xml           compact-pentax.xml     mil-fujifilm.xml   mil-sony.xml     slr-konica-minolta.xml  slr-samyang.xml    slr-vivitar.xml
compact-fujifilm.xml        compact-ricoh.xml      mil-nikon.xml      mil-tamron.xml   slr-leica.xml           slr-schneider.xml  slr-zeiss.xml
compact-kodak.xml           compact-samsung.xml    mil-olympus.xml    mil-tokina.xml   slr-nikon.xml           slr-sigma.xml      timestamp.txt
compact-konica-minolta.xml  compact-sigma.xml      mil-panasonic.xml  mil-zeiss.xml    slr-olympus.xml         slr-soligor.xml
compact-leica.xml           compact-sony.xml       mil-pentax.xml     misc.xml         slr-panasonic.xml       slr-sony.xml

Note that it's version_2 rather than version_1 in your example.

Also it doesn't work in the 5.8.0 release appimage or the 5.9.0 appimage I downloaded. The "Make", "Model" and "Lens" menus are all empty.
The menus are populated in the copy of 5.6.0 which I have installed but don't pick up on the new data.
Comment 7 caulier.gilles 2018-07-01 10:12:26 UTC
Good news.

Lensfun team provide an offcial alpha release 0.3.95

http://lensfun.sourceforge.net/news/

I checked DK code, and all compile fine with this new version of the library, event if a lots of deprecated functions are used in DK.

So i can switch the bundles to use this new version.

Gilles Caulier
Comment 8 caulier.gilles 2018-07-03 13:10:38 UTC
Git commit 3b4b466fec9921efba793c9ad26eed7b75082cca by Gilles Caulier.
Committed on 03/07/2018 at 13:09.
Pushed by cgilles into branch 'master'.

use lensfun 3.95 alpha release with bundles

M  +5    -7    project/bundles/3rdparty/ext_lensfun/CMakeLists.txt
D  +0    -13   project/bundles/3rdparty/ext_lensfun/lensfun-regex-mxe.patch

https://commits.kde.org/digikam/3b4b466fec9921efba793c9ad26eed7b75082cca
Comment 9 caulier.gilles 2018-07-05 09:16:25 UTC
Git commit 3f153706b81136b9f80385f541e948beccd86cfa by Gilles Caulier.
Committed on 05/07/2018 at 09:15.
Pushed by cgilles into branch 'master'.

Lensfun 3.9 alpha use a new sub directory named "version_2" to host XML lens database

R  +0    -0    core/Mainpage.dox [from: Mainpage.dox - 100% similarity]
M  +14   -4    core/libs/dimg/filters/lens/lensfuniface.cpp

https://commits.kde.org/digikam/3f153706b81136b9f80385f541e948beccd86cfa
Comment 10 caulier.gilles 2018-07-05 12:04:27 UTC
The last 6.0.0 pre release AppImage use now Lensfun 3.95 alpha version and it's suitable as well...
Comment 11 caulier.gilles 2018-07-05 12:04:50 UTC
https://files.kde.org/digikam/