Bug 390263 - Desktop icon spaces are inconsistent
Summary: Desktop icon spaces are inconsistent
Status: CLOSED NOT A BUG
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-11 12:51 UTC by Nick Stefanov
Modified: 2018-02-13 11:07 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Desktop icons are inconsistent (539.27 KB, image/png)
2018-02-11 12:51 UTC, Nick Stefanov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Stefanov 2018-02-11 12:51:36 UTC
Created attachment 110533 [details]
Desktop icons are inconsistent

The spaces between icons are inconsistent. This problem is present in 5.12 and in many older versions too. See the attachment. Please fix it for we have to edit FolderView.qml every time when update is being issued.
Comment 1 Nate Graham 2018-02-12 22:13:36 UTC
What's happening is that the tallest icon is determining the grid size for all the others. In fact, your complaint is that the grid is too *consistent*!

Not sure what we could do about this. Can you attach your edited FolderView.qml file as well as a screenshot for how it looks *when there are multiple columns of  icons*?
Comment 2 Nick Stefanov 2018-02-12 23:14:02 UTC
Someone has renamed my bug! I named it "Desktop icon spaces are inconsistent". I repeat - the spaces are inconsistent no matter which icon is first.
Comment 3 Nick Stefanov 2018-02-12 23:27:00 UTC
To receive consistent folder spaces In FolderView.qml I edit the following lines:

var iconWidth = iconSize + (6 * units.largeSpacing) + (0 * units.smallSpacing);

and

var iconHeight = iconSize + (theme.mSize(theme.defaultFont).height * plasmoid.configuration.textLines) + (0 * units.smallSpacing);

The inconsistent effect is with the default settings of FolderView.qml. When I edit it the spaces are correct. See the screenshot below:


https://s10.postimg.org/pdv5zuvkp/Consistent_spaces.png

The problem is not only on my installation. I tried brand new installation where the inconsistent effect is also present.
Comment 4 Nate Graham 2018-02-12 23:46:20 UTC
Does it still look good if you rename any of those icons to have a title long enough to wrap onto the next row?
Comment 5 Eike Hein 2018-02-13 08:55:02 UTC
You can achieve the same effect by simply setting text lines to 1.
Comment 6 Nick Stefanov 2018-02-13 10:19:18 UTC
Where? In FolderView.qml? No if I set it to 1, the icons gets very near to the left side.

(In reply to Nate Graham from comment #4)

> Does it still look good if you rename any of those icons to have a title
> long enough to wrap onto the next row?

The problem isn't the icon's names. It's ridiculous to fill two rolls of every icon on the desktop to receive consistency. Plasma is the only one DE with such problems.

Install Plasma5 and set different types of icons on the desktop and you'll have the same effect. It's a bug and I don't understand why my bug is with "Invalid" status.
Comment 7 Eike Hein 2018-02-13 10:20:27 UTC
Not in the QML. In the config dialog on the "Icons" page.
Comment 8 Nick Stefanov 2018-02-13 10:52:29 UTC
Ok, the bug it isn't for how we arrange icons on the desktop. The bug is for inconsistent spaces between icons on the desktop. You don't need to set something - brand new installation->set some different types of icons->the bug is there. I send my edited desktop screenshot only for reference how shoud it be. The default behaviour is in attachment.
Comment 9 Eike Hein 2018-02-13 10:57:43 UTC
It's not inconsistent. The default is two lines of text, which means every icon is given the space for two lines of text (even if there's only one line to display) to make it consistent. If you want a consistent single-line grid instead, you change the number of text lines.
Comment 10 Nick Stefanov 2018-02-13 11:07:24 UTC
Ok, I'll try but it's ridiculous such setting to destroy whole desktop...