Bug 390245 - Add a label to the window decoration customization button.
Summary: Add a label to the window decoration customization button.
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: decorations (show other bugs)
Version: 5.12.0
Platform: Neon Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: accessibility, junior-jobs, usability
: 391617 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-02-11 03:33 UTC by ritalat
Modified: 2018-06-20 01:19 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
System Settings - Window Decorations (134.58 KB, image/png)
2018-06-19 03:45 UTC, uRohan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ritalat 2018-02-11 03:33:10 UTC
The settings for window decorations are incredibly easy to miss. The button currently only has an ambiguous icon and it can easily be misinterpreted as a demo widget like the ones in widget style settings.

A simple "Customize" label would make it more obvious.
Comment 1 Christoph Feck 2018-02-22 18:49:10 UTC
A button without a label, or at least a tooltip, is not accessible.

I suggest "Configure..." as this is the default term we use for these items.
Comment 2 Nate Graham 2018-03-10 04:37:21 UTC
*** Bug 391617 has been marked as a duplicate of this bug. ***
Comment 3 Nate Graham 2018-03-10 04:54:03 UTC
I've submitted a patch for this: https://phabricator.kde.org/D11201
Comment 4 Nate Graham 2018-03-28 17:34:00 UTC
Git commit 7cde4b1028e2a8875bbae28c933f37d1e656502f by Nathaniel Graham.
Committed on 28/03/2018 at 17:33.
Pushed by ngraham into branch 'master'.

Make the Window Decoration themes' Configure buttons more obvious

Summary:
As documented via bug reports and online support requests, many users have difficulty learning that window decorations are customizable, because they don't notice or understand the little icon-only button in the bottom-left corner of each theme preview.

This patch centers the buttons and adds text including the theme name , making it obvious what the buttons are for.

Also, clicking on one of the buttons now automatically selects its corresponding theme, because configuring an un-selected theme doesn't make a lot of sense and could lead to user confusion once this UI is more obvious and widely-used.

Test Plan:
{F5761897}

- Clicked on the configure buttons; each one selects its parent theme and opens its configuration dialog

Reviewers: #kwin, #plasma, #vdg, cfeck, graesslin

Reviewed By: #kwin, #plasma, graesslin

Subscribers: richardbowen, zzag, kigwana, rkflx, matheusm, fabianr, abetts, Fuchs, graesslin, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D11201

M  +29   -8    kcmkwin/kwindecoration/qml/Previews.qml

https://commits.kde.org/kwin/7cde4b1028e2a8875bbae28c933f37d1e656502f
Comment 5 uRohan 2018-06-19 03:44:43 UTC
I think adding a theme name to a configuration button text is a bad idea (it looks not very good when theme has a long name). Although, maybe this is just an exception.
Comment 6 uRohan 2018-06-19 03:45:08 UTC
Created attachment 113417 [details]
System Settings - Window Decorations
Comment 7 Nate Graham 2018-06-19 03:47:13 UTC
Hmm.

Maybe we should change the text to always say "Configure theme..."

Or maybe we could elide the text before the button exceeds the bounds of its virtual window.

Or maybe we could make the button become taller and accommodate a multi-line string? Can it do that?

Or maybe this is a niche edge case and it's fine the way it is.

Thoughts?
Comment 8 uRohan 2018-06-20 01:16:57 UTC
(In reply to Nate Graham from comment #7)
> Hmm.
> 
> Maybe we should change the text to always say "Configure theme..."
> 
> Or maybe we could elide the text before the button exceeds the bounds of its
> virtual window.
> 
> Or maybe we could make the button become taller and accommodate a multi-line
> string? Can it do that?
> 
> Or maybe this is a niche edge case and it's fine the way it is.
> 
> Thoughts?

Or maybe it's just my nitpicking. :)

For me the best solution will be to make fixed-size button and display as much text as it can hold with adding three dots at the end (for example "Configure Evolvere Light..." and display the whole text in the tooltip (for example "Configure Evolvere Light Pure Circle Inverted decoration/theme").

It's so strange that for the designation of one thing two terms are used: "Decoration" and "Theme". ("Window Decorations" settings section, "Theme" tab, "Get New Decorations..." button).

Or am I missing something?
Comment 9 uRohan 2018-06-20 01:19:46 UTC
*As for me...

It's just IMHO :)