Bug 390198 - Please make sdc.py work also with (or switch it to) Python 3
Summary: Please make sdc.py work also with (or switch it to) Python 3
Status: CLOSED FIXED
Alias: None
Product: KDb
Classification: Frameworks and Libraries
Component: General (show other bugs)
Version: 3.1.0 Beta
Platform: Compiled Sources All
: NOR normal
Target Milestone: 3.1
Assignee: Kavinda
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2018-02-10 07:50 UTC by Pino Toscano
Modified: 2018-03-21 23:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 3.1.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pino Toscano 2018-02-10 07:50:53 UTC
Right now tools/sdc.py seems to be a Python2-only script, and the build system (cmake/modules/KDbCreateSharedDataClasses.cmake) indeed requires Python2 to be installed to build kdb.

Since Python2 will become EOL soon (https://pythonclock.org/), please make sdc.py work with Python3 as well (or switch it to Python3 exclusively), so Python2 will not be required to build kdb. Distributions are switching to Python3 as default, and at the same time working on reducing the need for Python2.
Comment 1 Jarosław Staniek 2018-02-14 10:47:02 UTC
Git commit 7e5633c36316cd8cf180eae982c5bc4574bb62bf by Jaroslaw Staniek, on behalf of Kavinda Pitiduwa Gamage.
Committed on 14/02/2018 at 10:46.
Pushed by staniek into branch '3.1'.

Add python 3 support for SDC

Summary:
FIXED-IN:3.1.0

Reviewers: #kdb

Tags: #kdb

Differential Revision: https://phabricator.kde.org/D10477

M  +1    -1    cmake/modules/KDbCreateSharedDataClasses.cmake
M  +89   -86   tools/sdc.py

https://commits.kde.org/kdb/7e5633c36316cd8cf180eae982c5bc4574bb62bf
Comment 2 Jarosław Staniek 2018-02-14 11:04:20 UTC
Git commit 6b4dc75a159b3d4a7e3302bbb3dc0adc7ec35542 by Jaroslaw Staniek, on behalf of Kavinda Pitiduwa Gamage.
Committed on 14/02/2018 at 11:03.
Pushed by staniek into branch '3.1'.

Add python 3 support for SDC
FIXED-IN:3.1.0

Port from KDb https://phabricator.kde.org/D10477

M  +4    -4    cmake/modules/KDbCreateSharedDataClasses.cmake
M  +89   -86   tools/sdc.py

https://commits.kde.org/kreport/6b4dc75a159b3d4a7e3302bbb3dc0adc7ec35542
Comment 3 Jarosław Staniek 2018-02-14 11:06:20 UTC
Git commit f57a3a36f08b444bf4249a3286798a94469d2184 by Jaroslaw Staniek, on behalf of Kavinda Pitiduwa Gamage.
Committed on 14/02/2018 at 11:05.
Pushed by staniek into branch 'master'.

Add python 3 support for SDC
FIXED-IN:3.1.0

Port from KDb https://phabricator.kde.org/D10477

M  +4    -4    cmake/modules/KDbCreateSharedDataClasses.cmake
M  +89   -86   tools/sdc.py

https://commits.kde.org/kreport/f57a3a36f08b444bf4249a3286798a94469d2184