Bug 390113 - [Wayland] Window dragged down is not unmaximized when I use a touch screen
Summary: [Wayland] Window dragged down is not unmaximized when I use a touch screen
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: input (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL: https://phabricator.kde.org/D10431
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-08 22:47 UTC by Patrick Silva
Modified: 2018-02-22 08:39 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.12.3
mgraesslin: Wayland+
mgraesslin: X11-
mgraesslin: ReviewRequest+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-02-08 22:47:17 UTC
My summary says by itself.
I can unmaximize when I use touchpad or usb mouse.

Neon dev unstable.
Comment 1 Martin Flöser 2018-02-09 20:43:04 UTC
Can confirm. What I also noticed while playing with it: all the quick tiling regions don't work, either.
Comment 2 Martin Flöser 2018-02-09 20:45:53 UTC
Fun thing to try: maximize a window, touch the decoration (but don't move) so that it goes into move resize mode, then use the arrow keys on your keyboard to move down -> window unmaximizes.

The touch properly enters move resize, but we seem to not operate correctly on the updates.
Comment 3 Martin Flöser 2018-02-10 17:49:32 UTC
Working on a patch, looks quite optimistic.
Comment 4 Martin Flöser 2018-02-10 20:05:41 UTC
Patch at: https://phabricator.kde.org/D10431
Comment 5 Martin Flöser 2018-02-22 08:39:56 UTC
Git commit 338c7362c9fbb37f1fb8beb9a50644b585d8135e by Martin Flöser.
Committed on 21/02/2018 at 17:06.
Pushed by graesslin into branch 'Plasma/5.12'.

Properly handle move during touch events

Summary:
When a window was being moved the touch handling performed the wrong
interaction. Due to that it was possible to move the window, but KWin
did not enter the correct code paths, thus quick tiling was for example
not functional.
FIXED-IN: 5.12.3

Test Plan: New test case added and manual test in nested KWin

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10431

M  +69   -1    autotests/integration/quick_tiling_test.cpp
M  +15   -7    input.cpp

https://commits.kde.org/kwin/338c7362c9fbb37f1fb8beb9a50644b585d8135e