Bug 390076 - Some GUI elements looks pixelated when I increase display scale
Summary: Some GUI elements looks pixelated when I increase display scale
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.12.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
: 389537 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-02-08 13:59 UTC by Patrick Silva
Modified: 2018-02-14 15:26 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: KDE Frameworks 5.44
Sentry Crash Report:


Attachments
screenshot (48.84 KB, image/png)
2018-02-08 13:59 UTC, Patrick Silva
Details
filter and trash icons (2.01 KB, image/png)
2018-02-09 13:23 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-02-08 13:59:41 UTC
Created attachment 110430 [details]
screenshot

Diascover 5.12 on Arch Linux.
My display scale is 1.2 under X11.

See my screenshot. Logo in blue area, ">" in sidebar and icon below "procurando atualizações" look pixelated. 
Apps icons are pixelated too, but I think this is another issue.
Comment 1 Aleix Pol 2018-02-09 01:47:23 UTC
Git commit d7d7904b5a8e8cca03216907f1b3ee0707aa0f08 by Aleix Pol.
Committed on 09/02/2018 at 01:45.
Pushed by apol into branch 'Plasma/5.12'.

Show a beautiful disabled icon for updates

M  +1    -0    discover/qml/UpdatesPage.qml

https://commits.kde.org/discover/d7d7904b5a8e8cca03216907f1b3ee0707aa0f08
Comment 2 Nate Graham 2018-02-09 03:37:39 UTC
Hmm, it almost seems like the Qt::AA_UseHighDpiPixmaps call isn't being picked up, because that's supposed to fix this. I tested it out and this change doesn't fix other examples of the issue, such as the fuzzy arrow icons. Dr Chapatin is right: SVG assets like the arrows and the "No updates available" image shouldn't be fuzzy in HiDPI mode at all. I fixed a similar problem for KInfoCenter recently: https://cgit.kde.org/kinfocenter.git/commit/?id=fdd2fc881157c21fd8a7eb3b8b5b0867b3f24c4e

Though it's probably not the same thing here, since we're already setting Qt::AA_UseHighDpiPixmaps
Comment 3 Patrick Silva 2018-02-09 13:23:29 UTC
Created attachment 110484 [details]
filter and trash icons

filter and trash icons in "settings" are affected.
Comment 4 Aleix Pol 2018-02-09 18:27:59 UTC
https://phabricator.kde.org/D10413
Comment 5 Aleix Pol 2018-02-09 18:31:17 UTC
Git commit 68a2ceb60e805fcdef10669f2415c6a3084898cf by Aleix Pol.
Committed on 09/02/2018 at 18:31.
Pushed by apol into branch 'master'.

Only multiply the icon size if Qt isn't doing it already

Summary:
This multiplication is redundant with Qt and will introduce awkward
scaling to images and poor rendering.

Reviewers: #kirigami, mart

Reviewed By: #kirigami, mart

Subscribers: plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D10413

M  +2    -1    src/desktopicon.cpp

https://commits.kde.org/kirigami/68a2ceb60e805fcdef10669f2415c6a3084898cf
Comment 6 Nate Graham 2018-02-14 15:26:42 UTC
*** Bug 389537 has been marked as a duplicate of this bug. ***