Bug 390053 - Many apps don't get a review button
Summary: Many apps don't get a review button
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.12.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-08 03:35 UTC by Nate Graham
Modified: 2018-02-09 01:54 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
No review button for Pitivi (372.03 KB, image/png)
2018-02-08 03:35 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-02-08 03:35:31 UTC
Created attachment 110422 [details]
No review button for Pitivi

This happens with my Kubuntu 17.10 (with Plasma 5.12) and KDE Neon (git master) machine. Many apps don't actually show a review button on the reviews pop-up, so you can't add a review. I haven't been able to figure out a pattern, but all GNOME apps seem to be affected. VLC, Transmission, GIMP and Blender aren't. Backend makes no difference.
Comment 1 Aleix Pol 2018-02-09 01:39:53 UTC
It's because we hide it for applications that aren't installed. Maybe disabling it would be less magic?
Comment 2 Nate Graham 2018-02-09 01:48:25 UTC
Heh, for some reason I just never made that connection! Disabling the button instead of removing it would definitely shine a light on the situation. Even better if its disabled state had a tooltip saying "You can only review installed apps" or something like that.
Comment 3 Aleix Pol 2018-02-09 01:54:10 UTC
Git commit f66ab0fa45a1180f82873d74229c21616d4681c7 by Aleix Pol.
Committed on 09/02/2018 at 01:53.
Pushed by apol into branch 'Plasma/5.12'.

Disable Review button for resources that aren't installed

Rather than hiding them which could be confusing.

M  +2    -1    discover/qml/ReviewsPage.qml

https://commits.kde.org/discover/f66ab0fa45a1180f82873d74229c21616d4681c7