Bug 390038 - Desktop Toolbox should be in top-right corner to keep it from intruding on Folder View icons
Summary: Desktop Toolbox should be in top-right corner to keep it from intruding on Fo...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Edit Mode toolbar (show other bugs)
Version: 5.12.0
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
: 390278 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-02-07 19:57 UTC by Nate Graham
Modified: 2018-02-28 23:51 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.13.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-02-07 19:57:06 UTC
This comes up a lot. E.g.

- "Desktop toolbox default position is on the left and intersects icons. Moving it to the right would make more sense" (https://www.reddit.com/r/kde/comments/7vpwb5/plasma_512_bug_thread/dtvyz81/)

"Specifically, the widget button on the left side sits too close to the desktop icons. A placement on the right side would make more sense" (http://www.ocsmag.com/2018/01/27/plasma-5-12-long-term-sweetness/)

We should consider moving the Desktop Toolbox to the top-right corner by default to alleviate this visual papercut.
Comment 1 David 2018-02-07 20:20:30 UTC
Can confirm. Steps to reproduce: Boot a NEON live image. Check the positioning of the desktop icons and the toolbox.
Comment 2 Kai Uwe Broulik 2018-02-07 20:36:59 UTC
It is actually supposed to be but is broken. The positioning logic is quite delicate. I'll have a look again.
Comment 3 Nate Graham 2018-02-15 17:28:29 UTC
Sources seem to say that it wants to be on the top left: https://cgit.kde.org/plasma-desktop.git/tree/containments/desktop/package/contents/config/main.xml?h=Plasma/5.12#n21

Can we change that?
Comment 4 Rik Mills 2018-02-15 17:29:25 UTC
Default is topleft:

https://cgit.kde.org/plasma-desktop.git/tree/containments/desktop/package/contents/config/main.xml?h=Plasma/5.12#n23

    <entry name="ToolBoxButtonState" type="String">
      <label>Position state of the toolbox button.</label>
      <default>topleft</default>

I patched that in Kubuntu to make a permanent change to the right.
Comment 5 Kai Uwe Broulik 2018-02-15 22:16:28 UTC
https://phabricator.kde.org/D10563
Comment 6 Kai Uwe Broulik 2018-02-23 10:38:05 UTC
Git commit b2588104cc562a0500b32c186aa11a6b8affddc4 by Kai Uwe Broulik.
Committed on 23/02/2018 at 10:37.
Pushed by broulik into branch 'master'.

Place toolbox in the top right corner of the screen

This moves it out of the way of desktop icons and is also what Plasma 4 did.
The code is adjusted to mirror the position for right-to-left languages.
FIXED-IN: 5.13.0

Differential Revision: https://phabricator.kde.org/D10563

M  +1    -1    containments/desktop/package/contents/config/main.xml
M  +10   -0    toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

https://commits.kde.org/plasma-desktop/b2588104cc562a0500b32c186aa11a6b8affddc4
Comment 7 Christoph Feck 2018-02-28 23:51:13 UTC
*** Bug 390278 has been marked as a duplicate of this bug. ***