Bug 390035 - No "Name" field in Add Review pop-up
Summary: No "Name" field in Add Review pop-up
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.12.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-07 19:29 UTC by Nate Graham
Modified: 2019-03-27 18:55 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/discover/e9d77bab1f34585afef9a764f75914258a7bdc0f
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-02-07 19:29:09 UTC 
Discover shows user reviews along with the reviewer's name, but offers its own users no "Name" field when they use Discover to *write* a review.
Comment 1 Nate Graham 2018-02-12 17:30:09 UTC 
Seems it takes the name from your current user account. I discovered by this by accident when I posted a review from within my development VM, and produced a review for Okular written by "dev". Oops.
Comment 2 Aleix Pol 2018-02-12 19:06:58 UTC 
Git commit e9d77bab1f34585afef9a764f75914258a7bdc0f by Aleix Pol.
Committed on 12/02/2018 at 19:05.
Pushed by apol into branch 'master'.

Show the name that will be used

Maybe we'd like to make it easy to modify?

M  +5    -0    discover/qml/ReviewDialog.qml
M  +2    -1    discover/qml/ReviewsPage.qml
M  +1    -1    libdiscover/ReviewsBackend/AbstractReviewsBackend.h
M  +6    -0    libdiscover/appstream/OdrsReviewsBackend.cpp
M  +1    -1    libdiscover/appstream/OdrsReviewsBackend.h

https://commits.kde.org/discover/e9d77bab1f34585afef9a764f75914258a7bdc0f
Comment 3 Nate Graham 2018-02-12 19:19:55 UTC 
I think we do need to make it easy to change, or else we're just frustrating people who see a name they want to change but can't do it.

Want another bug for that?
Comment 4 Nate Graham 2019-03-27 18:55:44 UTC 
Here is that bug: Bug 405935.